Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Close / open fieldset buttons need better descriptors #12892

Closed
aphelionz opened this issue Jul 16, 2017 · 0 comments · Fixed by #13780
Closed

[Accessibility] Close / open fieldset buttons need better descriptors #12892

aphelionz opened this issue Jul 16, 2017 · 0 comments · Fixed by #13780
Assignees
@timroes @thomasneirynck
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility

Comments

@aphelionz
Copy link
Contributor

Under visualizations there are several collapsible field editors. The controls that open and close them could benefit from better screen reader cues.

This one says "open editor" and "close editor" which is good, but it should be "open metrics editor" and "close metrics editor"

image

This one says "Grid" but it shoudl say "open grid options / close grid options" or some such thing

image

Likewise these two:

image

Finally, this one updates properly but I'm wondering if we need the screen reader to read it again upon activation:

image
@aphelionz aphelionz added Project:Accessibility Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jul 16, 2017
@cjcenizal cjcenizal mentioned this issue Jul 16, 2017
Closed
20 tasks
@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@thomasneirynck thomasneirynck self-assigned this Aug 23, 2017
@timroes timroes self-assigned this Aug 30, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Aug 30, 2017
Fix all agg options collapsables, fix elastic#12892
942ab08
@timroes timroes mentioned this issue Aug 30, 2017
Merged
timroes added a commit that referenced this issue Aug 31, 2017
@timroes
Improve accessibility of the visualize editor (#13780)
301452f 
* Use aria-expanded and better labels for agg collapsables

* Fix all agg options collapsables, fix #12892

* Label all vis editor inputs correctly, fix #11859

* Fix broken functional test
timroes added a commit that referenced this issue Aug 31, 2017
@timroes
Improve accessibility of the visualize editor (#13780)
99acc17 
* Use aria-expanded and better labels for agg collapsables

* Fix all agg options collapsables, fix #12892

* Label all vis editor inputs correctly, fix #11859

* Fix broken functional test
timroes added a commit that referenced this issue Aug 31, 2017
@timroes
Improve accessibility of the visualize editor (#13780)
b296d86 
* Use aria-expanded and better labels for agg collapsables

* Fix all agg options collapsables, fix #12892

* Label all vis editor inputs correctly, fix #11859

* Fix broken functional test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

@thomasneirynck thomasneirynck

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve accessibility of the visualize editor timroes/kibana
4 participants
@aphelionz @timroes @tbragin @thomasneirynck