Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Bug] Only favorites template not selected instead non favorites template selected if non favorites and only favorites templates have same name #130366

Closed
ghost opened this issue Apr 15, 2022 · 9 comments
Closed

[Security Solution] [Bug] Only favorites template not selected instead non favorites template selected if non favorites and only favorites templates have same name #130366

ghost opened this issue Apr 15, 2022 · 9 comments
Labels
8.4 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.4.0

Comments

@ghost
Copy link

ghost commented Apr 15, 2022 •
edited by ghost
Loading

Describe the bug:
Only favorites template not selected instead non favorites template selected if non favorites and only favorites templates have same name

Kibana/Elasticsearch Stack version:

Version: 8.2.0-Snapshot
Build: 51940
Commit: cbab89d8a43311d11dfaac3d9145a2be8841a857

Pre-conditions:

  1. Elastic Search should be up and running
  2. Kibana should be up and running
  3. Favorites template and non favorites templated having same name should be available.
  4. Custom rules should be created.

Steps to reproduce:

  1. Navigate to Rules-> Custom rules page under Security.
  2. Select the all rules or single rule.
  3. Select "Apply Timeline Template" Bulk action.
  4. Select the non favorites template from the drop-down.
  5. Now again click on only favorites filter from the drop-down.
  6. Select favorites template having same name.
  7. Now again click from the drop-down and observe that non favorites template selected instead of favorites template.
  8. Save the template.
  9. Click on custom rule and then click on edit rule settings.
  10. Observe that non favorites template selected under timeline template drop-down.

Current behavior:

  • Only favorites template not selected instead non favorites template selected if non favorites and only favorites templates have same name

Expected behavior:

  • Favorites template should selected if non favorites and only favorites templates have same name

What's working:

  • This issue is not occurring when only favorites and non favorites template selected.
Rules.-.Kibana.-.Google.Chrome.2022-04-15.15-59-35.mp4
  • This issue is not occurring when non favorites template having different name.
Rules.-.Kibana.-.Google.Chrome.2022-04-15.13-10-49.mp4

Screens Recording:

Rules.-.Kibana.-.Google.Chrome.2022-04-15.15-57-58.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.2.0 labels Apr 15, 2022
@ghost ghost self-assigned this Apr 15, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 15, 2022
@ghost ghost added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Apr 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 15, 2022
@ghost ghost assigned MadameSheema and unassigned ghost Apr 15, 2022
@ghost ghost added the triage_needed label Apr 15, 2022
@MadameSheema MadameSheema removed their assignment Apr 19, 2022
@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team labels Apr 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Apr 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@banderror banderror mentioned this issue Apr 19, 2022
Closed
@banderror banderror added the Feature:Rule Management Security Solution Detection Rule Management label Apr 19, 2022
@banderror
Copy link
Contributor

Another related one: #128740

Not sure that we own this component, but I did add both of these bugs to the Rules Area backlog.

@banderror banderror removed their assignment Apr 19, 2022
@banderror banderror removed the v8.2.0 label Apr 19, 2022
@michaelolo24 michaelolo24 removed their assignment Apr 27, 2022
@michaelolo24
Copy link
Contributor

I think this is related to this work: #120472

@banderror
Copy link
Contributor

@michaelolo24 do you know if PickTimeline or SearchTimelineSuperSelect are used from any other components except rule creation/editing form and rules bulk editing form? SearchTimelineSuperSelect lives in x-pack/plugins/security_solution/public/timelines/components/timeline/ but seems like we're the only user of it.

@kqualters-elastic
Copy link
Contributor

Absolutely shocked to find some eslint disables in the hooks that control this behavior 😆 https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/detections/components/rules/pick_timeline/index.tsx#L37-#L56

@vitaliidm vitaliidm mentioned this issue Jul 5, 2022
Merged
1 task
vitaliidm added a commit that referenced this issue Jul 6, 2022
@vitaliidm
[Security Solution][Detections] fixes timeline template selection whe…
d2bc9ab 
…n templates have same name #135694

## Summary

- addresses #130366
- instead of checking title and id when changing selection, only id will be checked

### Before

Impossible to select timeline template, if previously selected one has the same name

https://user-images.githubusercontent.com/92328789/177312907-bdc588c6-2811-430d-855a-6c957a65a8f8.mov


### After
Possible to select timeline template, if previously selected one has the same name

https://user-images.githubusercontent.com/92328789/177313210-81519771-10c5-4959-bcd2-db46c8d4a41f.mov


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Release note
fixes issue when users were not able to select timeline template on rules edit/create page and bulk actions if templates have the same name
@vitaliidm
Copy link
Contributor

@vipulsrivastava-qasource , issue has been addressed in #135694 and ready for testing

@vitaliidm vitaliidm added fixed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 6, 2022
@vitaliidm vitaliidm assigned ghost and unassigned vitaliidm Jul 6, 2022
@ghost
Copy link
Author

ghost commented Jul 29, 2022

Hi @vitaliidm

We have validated this issue on v8.4.0-BC1 build and found that issue is Fixed.

Please find the below build and testing details.

Build Details:

VERSION: 8.4.0
BUILD: 54999
COMMIT: 58f7eaf0f8dc3c43cbfcd393e587f155e97b3d0d

Screencast

Rules.-.Kibana.-.favourite.-.template.mp4

Hence, we are closing this issue and marking as QA Validated!!

Thanks!!

@ghost ghost closed this as completed Jul 29, 2022
@ghost ghost added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 29, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.4 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@banderror @elasticmachine @michaelolo24 @MadameSheema @kqualters-elastic @vitaliidm