Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search] Provide option to disable filter pinning #131813

Closed
kertal opened this issue May 9, 2022 · 4 comments · Fixed by #132037
Closed

[Unified Search] Provide option to disable filter pinning #131813

kertal opened this issue May 9, 2022 · 4 comments · Fixed by #132037
Labels
enhancement New value added to drive a business result Feature:Alerting Feature:Discover Discover Application loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented May 9, 2022

Describe the feature:

When using the unified search bar with filters, there are plenty of useful actions available, like enabling, disabling, inverting filters. Another useful feature is pinning, so when switching from Discover to Dashboard, filters are kept. However this is not useful everywhere. Therefore pinning of filters should be configureable (it should be available or not be displayed).

Describe a specific use case for the feature:
When creating an Elasticsearch query rule in Discover, currently Pinning of filters is available. However, it makes no sense in this context, since it's a local searchSource with filters that can be changed:

Bildschirmfoto 2022-05-09 um 17 16 31

PR enabling editing with unified search bar: #131688

@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@kertal kertal added enhancement New value added to drive a business result Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels May 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor

@stratoula Hi Stratoula! I was looking into this ticket and found that Filter item already has hiddenPanelOptions prop. So I tried to make it also configurable for SearchBar component in dimaanj#6
Wdyt about this approach?

@stratoula
Copy link
Contributor

@jughosta yes I like your approach! Let's go with it. I think it is a nice enhancement for our SearchBar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Alerting Feature:Discover Discover Application loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
4 participants