[Discover][Unified Search][Alerting] Configurable filter menu options #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
reviewed
May 11, 2022
| @@ -63,6 +63,8 @@ const withDebounce = debounce((execute: () => void) => execute(), 500, { | |||
| trailing: true, | |||
| }); | |||
|
|
|||
| const HIDDEN_FILTER_PANEL_OPTIONS: SearchBarProps['hiddenFilterPanelOptions'] = ['pinFilter']; | |||
There was a problem hiding this comment.
@jughosta I think it's fine to create a PR to main excluding this file. seems just tests are missing. So we'd also get CI feedback.
|
Closing in favor of elastic#132037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic#131813
Summary
This PR allows to configure which filter options should be hidden from panels. For Alerting we would like to hide pinning functionality.
Default behaviour:
"Pinning" is hidden for Alerts in Discover page flyout:
