Replace task manager's runNow with runSoon #133550
Assignees
Labels
Feature:Alerting/RulesFramework
Issues related to the Alerting Rules Framework
Feature:Task Manager
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Comments
mikecote
added
Feature:Task Manager
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
mikecote
moved this from Awaiting Triage
to Todo
in AppEx: ResponseOps - Execution & Connectors
ersin-erdal
moved this from Todo
to In Progress
in AppEx: ResponseOps - Execution & Connectors
ersin-erdal
moved this from In Progress
to In Review
in AppEx: ResponseOps - Execution & Connectors
Repository owner
moved this from In Review
to Done
in AppEx: ResponseOps - Execution & Connectors
Jun 28, 2022
mikecote
added a commit
that referenced
this issue
Nov 9, 2022
In this PR, I'm cleaning up code within Task Manager regarding claiming tasks by id that is no longer used. The code was previously used for running alerting rules right away but recently `runNow` got replaced with `runSoon` which no longer needs this code to function. For more info on the previous change, see #133550.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TaskManager exposes the ability to run a background task immediately and wait for the task to finish running. This will no longer be feasible in all configurations when a Kibana process can be explicitly configured to no longer run background tasks.
Instead,
runSoonshould replacerunNowand adjust the task's schedule so that it is run as soon as possible by the next available Kibana process that can run background tasks. If we need these tasks to skip the current queue, we will need to add some type of priority to task-manager's claiming algorithm; however, this should be optional as not all consumers ofrunSoonwill want to skip the queue.Unlike
runNow,runSoonwill return as soon as the schedule has been updated and before the task has completed running.At the moment, the only consumers of
runNowoutside of alerting are APM. APM is using it to run their telemetry task when it's outdated. However, the results of the telemetry task are not consumed, so a transition torunSoonwill be rather painless. It's worth keeping in mind the usage of runNow when updating a rule will soon transition to a new function and may have merge conflicts (#124850).The text was updated successfully, but these errors were encountered: