-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route change announcements for Infrastructure inventory and host views #135874
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
[WIP] Questions/Notes:
|
@elastic/kibana-accessibility might be best able to advice here. |
Great questions @jennypavlova! I'll answer each bullet point as a point of its own.
|
The EUI team also put together a screen reader testing matrix that outlines what screen readers we support, and testing tiers: https://github.com/elastic/eui/blob/main/wiki/screen-reader-testing-matrix.md |
Notes (for myself this time 😄):
|
Ongoing discussion on #135760 indicates that they might be able to solve this at the platform level. Putting this back into the backlog until we have finalized guidance on how to finish this. |
…crumbs #135874 (#140824) * Use breadcrumbs to set page title intead of DocumentTitle * Remove document title component and use breadcrumbs - Logs Page * Remove no longer needed document title translations * Use docTitle.change in error page and remove document title component * Add document title check to the functional tests * Move test to check title after load * test: Title change * Remove unnecessary docTitle type * Add error page tests * Update snapshot * Functional tests: Wait for loading the header before checking the title * Change test to use react testing library Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Hey @smith is this one still needed? Moving to bottom of backlog based on last comment |
@roshan-elastic based on the discussion on the meta-issue this was created from it looks like we may not have to do anything here. I'm going to close this and we can reopen if needed. |
Great - thanks @smith |
See parent issue #135760.
Implement recommended solution for announcing the new location for client-side router route changes.
Do this on the infrastructure inventory and individual host pages.
✔️ Acceptance criteria
New page location is announced to screen readers when viewing these pages.
The text was updated successfully, but these errors were encountered: