-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Description
We are currently using Ace as a code editor in several places, e.g.:
- Query Filter UI
- Dev Tools Console
- Time Series Visual Builder Markdown
We use different frameworks (Angular, React) and different initialization mechanisms in these places. Meaning, that we currently have to reimplement the keyboard mode we introduced with #13339 for each of the places.
Also it appears Ace doesn't have the best accessibility in general, looking at some upstream issues:
We should consider how we handle Ace in the long run in Kibana. Should we try to provide upstream fixes for the keyboard interaction (there was even an interesting other suggestion in the ticket above), which would also prevent us from reimplementing it for every framework? Should we switch to a different (more accessible) code editor? Should we just fix the issues upsream to react-ace
(that we use in the TSVB) and convert the other places as soon as possible from Angular to React components?