Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/dashboard/group3/dashboard_state·ts - dashboard app - group 3 dashboard state Directly modifying url updates dashboard state for query parameter with hard refresh #139762

Closed
kibanamachine opened this issue Aug 30, 2022 · 8 comments · Fixed by #152245
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/dashboard/group3/dashboard_state·ts - dashboard app - group 3 dashboard state Directly modifying url updates dashboard state for query parameter with hard refresh #139762

kibanamachine opened this issue Aug 30, 2022 · 8 comments · Fixed by #152245
Assignees
@nreese
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Dashboard Dashboard related features impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 30, 2022 •
edited
Loading

A test failed on a tracked branch

Error: expected 'hi:goodbye' to equal 'hi:hello'
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.equal (node_modules/@kbn/expect/expect.js:227:8)
    at changeQuery (test/functional/apps/dashboard/group3/dashboard_state.ts:193:49)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Context.<anonymous> (test/functional/apps/dashboard/group3/dashboard_state.ts:202:9)
    at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 30, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 30, 2022
@jsanz jsanz added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 5, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Sep 8, 2022

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 4c3d562

kibanamachine added a commit that referenced this issue Sep 8, 2022
@kibanamachine
skip failing test suite (#139762)
4c3d562
@cuff-links cuff-links self-assigned this Nov 17, 2022
@bhavyarm bhavyarm assigned bhavyarm and unassigned cuff-links Dec 7, 2022
This was referenced Feb 1, 2023
Closed
Closed
@nreese nreese assigned nreese and unassigned bhavyarm Feb 2, 2023
@ThomThomson ThomThomson added the Feature:Dashboard Dashboard related features label Feb 10, 2023
@Heenawter Heenawter added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label Feb 21, 2023
@nreese nreese mentioned this issue Feb 27, 2023
Merged
nreese added a commit that referenced this issue Feb 28, 2023
@nreese @kibanamachine
unskip Chrome UI Functional Tests.test/functional/apps/dashboard/grou…
280b597 
…p3/dashboard_state·ts (#152245)

Fixes #139762

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1965

2 changes where required to get functional tests running
* Switch application state updating from string replace to rison
decode/encode. `_a` is not longer provided in the URL unless there are
unsaved changes to simple string replace did not work in some cases.
Using rison decode/encode was easier then handling a lot of if
statements around whether `_a` exists before attempting string replace,
plus rison decode/encode is a lot more maintainable and robust.
* Fix bug where appending `&_a=(panels:())` to URL would not remove
panels. Updated logic in sync_dashboard_url_state to handle case where
panels has no length.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@nreese @kibanamachine @bmorelli25
unskip Chrome UI Functional Tests.test/functional/apps/dashboard/grou…
daf00a2 
…p3/dashboard_state·ts (elastic#152245)

Fixes elastic#139762

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1965

2 changes where required to get functional tests running
* Switch application state updating from string replace to rison
decode/encode. `_a` is not longer provided in the URL unless there are
unsaved changes to simple string replace did not work in some cases.
Using rison decode/encode was easier then handling a lot of if
statements around whether `_a` exists before attempting string replace,
plus rison decode/encode is a lot more maintainable and robust.
* Fix bug where appending `&_a=(panels:())` to URL would not remove
panels. Updated logic in sync_dashboard_url_state to handle case where
panels has no length.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine reopened this May 16, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue May 21, 2024
@mistic
skip flaky suite (#139762)
c08a286
@mistic
Copy link
Member

mistic commented May 21, 2024

Skipped.

main: c08a286

@Heenawter
Copy link
Contributor

Closing in favour of #183752, since that is reporting the more accurate failure

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Dashboard Dashboard related features impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
10 participants
@jsanz @nreese @cuff-links @jbudz @mistic @bhavyarm @Heenawter @ThomThomson @elasticmachine @kibanamachine