Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBT] Collect console errors #140933

Open
Tracked by #140915
afharo opened this issue Sep 19, 2022 · 7 comments
Open
Tracked by #140915

[EBT] Collect console errors #140933

afharo opened this issue Sep 19, 2022 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Sep 19, 2022

On the browser side, we'd like to collect the error messages printed in the browser's console.

Note: It may include the events from #140932, so that other issue might not be relevant.

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result Feature:Telemetry labels Sep 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Contributor

It may include the events from #140932, so that other issue might not be relevant.

That was my first question 😅

What's the difference between this issue and #140932?

What are 'console errors'? Isn't that precisely uncaught errors and/or unhandled promise rejections? Do you see anything else here?

@afharo
Copy link
Member Author

afharo commented Sep 20, 2022

These might also include actively logged errors via console.error (there are quite a few in Kibana).

@lukeelmers
Copy link
Member

Totally agree having this data would be helpful, but curious how if you see this or #140932 relating to the proposal for a browser logging service?

For errors on the server, we don't really need EBT because we already have our server logs which can be analyzed at a large scale via the cloud overview cluster. If we ended up building a browser logging service that shipped logs to the server, we could potentially achieve the same thing (depending on how it was implemented).

So I'm wondering how we should be thinking about the role of EBT in collecting browser console logs vs an official browser logging service. Do we need both, or is one or the other preferable?

@pgayvallet
Copy link
Contributor

These might also include actively logged errors via console.error

++ for focusing on developing the client-side logging service and then collecting such errors from here (Also I'm not sure there's a way to hook into console.error usages that doesn't imply ugly monkey-patching?)

@afharo
Copy link
Member Author

afharo commented Sep 21, 2022

++ to the browser logging service: I think it'll unlock this and other needs we currently have.

It will make it much easier to hook events to that (wether we decide to ship them to the telemetry services or the server, that's up to us) :)

@pgayvallet
Copy link
Contributor

The browser-side logger was implemented in #144107, which may unblock this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants