Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided onboarding] Design polish #141223

Closed
1 task done
alisonelizabeth opened this issue Sep 21, 2022 · 11 comments
Closed
1 task done

[Guided onboarding] Design polish #141223

alisonelizabeth opened this issue Sep 21, 2022 · 11 comments
Labels
8.6 candidate enhancement New value added to drive a business result Team:Journey/Onboarding Platform Journey Onboarding team

Comments

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Sep 21, 2022

This issue is to track any design feedback that we need to follow-up on for the guided setup component:

  • Currently when a step is open, the other steps are not expandable when clicked, but we would like them to be. We want the user to be able to view the details of the other steps but only be able to start the current step as that one will be the only one with the start button PR comment ([Guided onboarding] Fix steps status #142526)
@alisonelizabeth alisonelizabeth added enhancement New value added to drive a business result 8.6 candidate Team:Journey/Onboarding Platform Journey Onboarding team labels Sep 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@cindychangy
Copy link
Contributor

cindychangy commented Oct 14, 2022

  • Progress Bar:
    -The text for the value (steps) should be in the color: darkShade .
    -Both thelabel and valueTex should be font-size: 12px.
    -Can we add a margin-bottom: 5px; to the parent .euiProgress__data div? The default does not give adequate spacing.

image

@cindychangy
Copy link
Contributor

cindychangy commented Oct 14, 2022

  • Revised Footer:
    Sorry this is a bit late, hopefully this is not a huge fix (I can also open a PR to do it as well, just let me know). We are condensing all of this to one line as seen in the screencap. The prototype shows this as well now (note: It looks like we will have to use some custom styling in the links and icons as it doesn't seem possible to achieve this look by default. Let me know if you see any complications and think this should be moved out of 8.6.

image

@alisonelizabeth
Copy link
Contributor Author

Hi @cindychangy! Thanks for the feedback.

Regarding the progress bar, the proposed changes seem like custom styling on top of the EUI component. Is that correct? I would prefer not to change the default. If we think something should change, let's open up an issue against EUI and address there. Let me know what you think.

Sorry this is a bit late, hopefully this is not a huge fix (I can also open a PR to do it as well, just let me know).

This seems straightforward enough, however, I would consider it a low-priority item for us given the remaining work. If you have time to open up a PR yourself, that would be helpful!

@cindychangy
Copy link
Contributor

This seems straightforward enough, however, I would consider it a low-priority item for us given the remaining work. If you have time to open up a PR yourself, that would be helpful!

Totally agree @alisonelizabeth, I will open a PR for the footer - thanks!

@bojanasan
Copy link

Adding a link to the new issue re: EUI Tour component interaction question (ability to dismiss by clicking out of the UI component.

@cindychangy
Copy link
Contributor

cindychangy commented Oct 25, 2022

@cindychangy
Copy link
Contributor

cindychangy commented Oct 25, 2022

Link to EUI issue for using custom sizes for icons.

@cindychangy
Copy link
Contributor

cindychangy commented Oct 27, 2022

  • Modify the panel to not have a fixed height and instead take the height of the content.

@alisonelizabeth, @yuliacech - re: the SIEM Figma discussion - do you see any issues with this? We are applying custom styling to the EuiFlyout already, so I think it is just a matter of adjusting those custom styles. I can open a PR for this, but let me know if you think there will be an issue.

@alisonelizabeth
Copy link
Contributor Author

@alisonelizabeth, @yuliacech - re: the SIEM Figma discussion - do you see any issues with this? We are applying custom styling to the EuiFlyout already, so I think it is just a matter of adjusting those custom styles. I can open a PR for this, but let me know if you think there will be an issue.

@cindychangy I think this is fine if you're able to take this on. Note that the EUI team updated their docs on how to create a custom flyout so we will eventually migrate to using EuiPortal (see #143878 for more details). This doesn't necessarily change anything, but just sharing for awareness.

@alisonelizabeth
Copy link
Contributor Author

I'm going to close this issue. I think we've addressed everything here, with the exception of:

Please open individual design polish issues from now on that we can track for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6 candidate enhancement New value added to drive a business result Team:Journey/Onboarding Platform Journey Onboarding team
Projects
None yet
Development

No branches or pull requests

4 participants