Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] - Replace the global feature-flag for the Alert Details page with App-based feature flag #142718

Closed
Tracked by #138645
fkanout opened this issue Oct 5, 2022 · 1 comment · Fixed by #142839
Labels
release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Oct 5, 2022

📝 Summary

Part of #138645

In #139216 we introduced the global feature flag xpack.observability.unsafe.alertDetails.enabled so the user can access the new Alert Details page FOR ALL RULE TYPES

While working on the Alert Details page we realized that the roll-out will be by App. e.g. We are targeting APM rule types first. In that case, providing a global feature flag is no more suitable for a roll-out by App.

✅ AC

  • Remove the global feature flag xpack.observability.unsafe.alertDetail.enabled
  • Instead, provide 4 feature flags:
    • xpack.observability.unsafe.alertDetails.apm.enabled
    • xpack.observability.unsafe.alertDetails.infra.enabled
    • xpack.observability.unsafe.alertDetails.logs.enabled
    • xpack.observability.unsafe.alertDetails.uptime.enabled
  • Creating a mapping between the rule type and the feature flag to decide whether to show the Alert flyout OR the Alert Details age
@fkanout fkanout added release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 labels Oct 5, 2022
@fkanout fkanout self-assigned this Oct 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants