Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InjectedMetadataSetup to be removed by 8.8 #147721

Closed
TinaHeiligers opened this issue Dec 16, 2022 · 4 comments · Fixed by #147840
Closed

InjectedMetadataSetup to be removed by 8.8 #147721

TinaHeiligers opened this issue Dec 16, 2022 · 4 comments · Fixed by #147840
Assignees
Labels
deprecation_warnings Epic:Deprecations Deprecations NeededFor:Core Team:Fleet Team label for Observability Data Collection Fleet team Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Dec 16, 2022

InjectedMetadataSetup is marked as deprecated to be removed by 8.8. However, remaining consumers are blocking the final removal:

getInjected: (name: string, defaultValue?: unknown): string | unknown =>
    core.injectedMetadata.getInjectedVar(name, defaultValue),
injectedMetadata: {
    getInjectedVar: () => null,
},

Consumers need to migrate away from the deprecated API for Core to remove the API.

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 16, 2022
@TinaHeiligers TinaHeiligers added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2022
@TinaHeiligers TinaHeiligers added deprecation_warnings technical debt Improvement of the software architecture and operational architecture Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers added NeededFor:Core and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 16, 2022
@TinaHeiligers TinaHeiligers changed the title getInjectedVar to be removed by 8.8 InjectedMetadataSetup to be removed by 8.8 Dec 16, 2022
@pgayvallet
Copy link
Contributor

pgayvallet commented Dec 20, 2022

I think we should be able to manage ourselves, none of the remaining usages seems to be, well, used.

  • fleet

injectedMetadata: {
getInjectedVar: () => null,
},

I couldn't find any usage of it, and the fact that it always return nil would tend to confirm that we can just delete it.

  • monitoring

getInjected: (name: string, defaultValue?: unknown): string | unknown =>
core.injectedMetadata.getInjectedVar(name, defaultValue),

Same, grepping in the plugin's code, I can only find 3 usages of getInjected, which are just the definition. I think we should be able to just delete the definition.

@pgayvallet pgayvallet self-assigned this Dec 20, 2022
pgayvallet added a commit that referenced this issue Dec 21, 2022
## Summary

Fix #147721

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@TinaHeiligers TinaHeiligers added the Epic:Deprecations Deprecations label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation_warnings Epic:Deprecations Deprecations NeededFor:Core Team:Fleet Team label for Observability Data Collection Fleet team Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants