-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]Incorrect Prevention and Detection Type Alert Count in Alert by Type Chart of Alert Page #150278
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@amolnater-qasource please review |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
@michaelolo24 @christineweng may you please take a look at the above issue? Thanks! |
@karanbirsingh-qasource just want to clarify, I noticed a few discrepancies in your screenshots, could you confirm the below 2 bugs as shown in your videos:
|
Thanks @christineweng for looking to the issue and please find below additional details regarding the above pointers. Moreover we have shared the instance credentials with you over gmail for more clarity. Count discrepancies between detection totals (101) and row detail totals (13)- could you share with me the inspect response for this scenario?_To Filter only Detections Type Alert ,we have first got the id value of 2 prevention alert and then applied the not filter on them as currently we could not find the filter for type field to apply Alerts.-.Kibana.Mozilla.Firefox.2023-02-07.11-19-27.mp4Alerts.-.Kibana.Mozilla.Firefox.2023-02-07.09-37-54.mp4
Request
Response
Count discrepancies between severity (2) and type (6), you shared the inspect request and response for type, could you share the same for severity?
Severity levels Request
Severity levels Response
Alerts by type Request
Alerts by type Response
Please let us known if there is any more information required from our end. thanks !! |
…lastic#150504) This PR addresses the following: #### Bug fix elastic#150278 described a discrepancy between total alert count in alert by type chart and everywhere else on alerts page. This is due to `event.type` being a multi-select, if an alert has 3 event types (i.e. creation, info, denied), it is counted 3 times on alert by type graph. This logic is now updated to categorize an alert once - if `denied` event type exists, such event count => `Prevention` - total alert count - prevention count => `Detection`. #### UI improvements - Top alerts chart no longer shows `Other` when number of grouping is less than 10 per elastic#150242 (comment) ![image](https://user-images.githubusercontent.com/18648970/217382166-073d2da9-f49d-4bf7-9a08-3795d5948e33.png) - Changed `EmptyDonutChart`'s background based on dark/light mode Before -> After ![image](https://user-images.githubusercontent.com/18648970/217382463-1ef44127-1cdf-4a70-85f2-8c78a612c485.png) - Loading spinner for donut chart was not showing, it is now fixed ![image](https://user-images.githubusercontent.com/18648970/217382665-93e093e3-119a-4be4-a313-072ef118eec7.png) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2846b8c)
@karanbirsingh-qasource this should be fixed on main, could you confirm? |
thanks for the update, however there is some issue on kibana mains on linux agent installation endpoint is in unhealthy state. so we will be re-testing this issue as soon we will get a healthy endpoint status and will regress out this issue. |
…ments (#150504) (#150649) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution][Bug] Alerts type discrepancy and ui improvements (#150504)](#150504) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-08T22:40:49Z","message":"[Security Solution][Bug] Alerts type discrepancy and ui improvements (#150504)\n\nThis PR addresses the following:\r\n\r\n#### Bug fix\r\nhttps://github.com//issues/150278 described a discrepancy\r\nbetween total alert count in alert by type chart and everywhere else on\r\nalerts page. This is due to `event.type` being a multi-select, if an\r\nalert has 3 event types (i.e. creation, info, denied), it is counted 3\r\ntimes on alert by type graph. This logic is now updated to categorize an\r\nalert once\r\n- if `denied` event type exists, such event count => `Prevention`\r\n- total alert count - prevention count => `Detection`.\r\n\r\n#### UI improvements\r\n- Top alerts chart no longer shows `Other` when number of grouping is\r\nless than 10 per\r\nhttps://github.com//pull/150242#issuecomment-1419628829\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382166-073d2da9-f49d-4bf7-9a08-3795d5948e33.png)\r\n- Changed `EmptyDonutChart`'s background based on dark/light mode \r\nBefore -> After\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382463-1ef44127-1cdf-4a70-85f2-8c78a612c485.png)\r\n- Loading spinner for donut chart was not showing, it is now fixed\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382665-93e093e3-119a-4be4-a313-072ef118eec7.png)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"2846b8c27cf7da5a9e5c8152177376fdb8d2cffe","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Investigations","v8.7.0","v8.8.0"],"number":150504,"url":"https://github.com/elastic/kibana/pull/150504","mergeCommit":{"message":"[Security Solution][Bug] Alerts type discrepancy and ui improvements (#150504)\n\nThis PR addresses the following:\r\n\r\n#### Bug fix\r\nhttps://github.com//issues/150278 described a discrepancy\r\nbetween total alert count in alert by type chart and everywhere else on\r\nalerts page. This is due to `event.type` being a multi-select, if an\r\nalert has 3 event types (i.e. creation, info, denied), it is counted 3\r\ntimes on alert by type graph. This logic is now updated to categorize an\r\nalert once\r\n- if `denied` event type exists, such event count => `Prevention`\r\n- total alert count - prevention count => `Detection`.\r\n\r\n#### UI improvements\r\n- Top alerts chart no longer shows `Other` when number of grouping is\r\nless than 10 per\r\nhttps://github.com//pull/150242#issuecomment-1419628829\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382166-073d2da9-f49d-4bf7-9a08-3795d5948e33.png)\r\n- Changed `EmptyDonutChart`'s background based on dark/light mode \r\nBefore -> After\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382463-1ef44127-1cdf-4a70-85f2-8c78a612c485.png)\r\n- Loading spinner for donut chart was not showing, it is now fixed\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382665-93e093e3-119a-4be4-a313-072ef118eec7.png)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"2846b8c27cf7da5a9e5c8152177376fdb8d2cffe"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150504","number":150504,"mergeCommit":{"message":"[Security Solution][Bug] Alerts type discrepancy and ui improvements (#150504)\n\nThis PR addresses the following:\r\n\r\n#### Bug fix\r\nhttps://github.com//issues/150278 described a discrepancy\r\nbetween total alert count in alert by type chart and everywhere else on\r\nalerts page. This is due to `event.type` being a multi-select, if an\r\nalert has 3 event types (i.e. creation, info, denied), it is counted 3\r\ntimes on alert by type graph. This logic is now updated to categorize an\r\nalert once\r\n- if `denied` event type exists, such event count => `Prevention`\r\n- total alert count - prevention count => `Detection`.\r\n\r\n#### UI improvements\r\n- Top alerts chart no longer shows `Other` when number of grouping is\r\nless than 10 per\r\nhttps://github.com//pull/150242#issuecomment-1419628829\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382166-073d2da9-f49d-4bf7-9a08-3795d5948e33.png)\r\n- Changed `EmptyDonutChart`'s background based on dark/light mode \r\nBefore -> After\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382463-1ef44127-1cdf-4a70-85f2-8c78a612c485.png)\r\n- Loading spinner for donut chart was not showing, it is now fixed\r\n\r\n![image](https://user-images.githubusercontent.com/18648970/217382665-93e093e3-119a-4be4-a313-072ef118eec7.png)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"2846b8c27cf7da5a9e5c8152177376fdb8d2cffe"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
we have validated this issue on 8.7.0-BC1 On-Prem Setup and found the issue still occuring . Alert count mismatch in Alert by Type Chart.
Build Details:
Screen-Cast: ksingh-window-m1-signing-off.-.ec2-52-6-226-191.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2023-02-10.11-27-30.mp4Please let us known if need more information regarding the issue. |
Hi @karanbirsingh-qasource I just checked and the fix did not make it to BC1 build, could you verify again when BC2 is ready? sorry! |
we have re validated the issue and found the issue to be fixed now ✔️ . Correct Total count and detection and prevention type alert count is showing on charts. Build Details:
Screen-Cast: Alerts.-.Kibana.Mozilla.Firefox.2023-02-16.15-58-09.mp4Hence we are closing the issue and adding "QA:Validated" tag to it. thanks !! |
Describe the bug
Incorrect Prevention and Detection Type Alert Count in Alert by Type Chart of Alert Page
Build Details:
Preconditions
Steps
Mimikatz.exe
Mimikatz.exe
Screen-Cast
Alerts.-.Kibana.Mozilla.Firefox.2023-02-06.12-25-58.mp4
Alerts.-.Kibana.Mozilla.Firefox.2023-02-06.12-27-34.mp4
Additional Information
Response
Request
The text was updated successfully, but these errors were encountered: