Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/dashboard_maps_by_value·ts - dashboard dashboard maps by value editing a map and adding to map library does not update the panel when only saving to library #152476

Closed
kibanamachine opened this issue Mar 1, 2023 · 15 comments · Fixed by #152850 or #168003
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/dashboard_maps_by_value·ts - dashboard dashboard maps by value editing a map and adding to map library does not update the panel when only saving to library #152476

kibanamachine opened this issue Mar 1, 2023 · 15 comments · Fixed by #152850 or #168003
Assignees
@nreese
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 1, 2023 •
edited
Loading

A test failed on a tracked branch

Error: retry.try timeout: Error: 1 elements still loading contents
    at renderable.ts:46:15
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.try (retry.ts:31:12)
    at RenderableService.waitForRender (renderable.ts:29:5)
    at DashboardPageObject.waitForRenderComplete (dashboard_page.ts:718:5)
    at editByValueMap (dashboard_maps_by_value.ts:70:5)
    at Context.<anonymous> (dashboard_maps_by_value.ts:137:9)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at RenderableService.waitForRender (renderable.ts:29:5)
    at DashboardPageObject.waitForRenderComplete (dashboard_page.ts:718:5)
    at editByValueMap (dashboard_maps_by_value.ts:70:5)
    at Context.<anonymous> (dashboard_maps_by_value.ts:137:9)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Mar 1, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 1, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Mar 1, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 647126a

kibanamachine added a commit that referenced this issue Mar 1, 2023
@kibanamachine
skip failing test suite (#152476)
647126a
@jughosta jughosta added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Mar 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 6, 2023
@Heenawter Heenawter added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label Mar 6, 2023
@Heenawter Heenawter self-assigned this Mar 6, 2023
@Heenawter Heenawter mentioned this issue Mar 6, 2023
Closed
2 tasks
@nreese
Copy link
Contributor

nreese commented Mar 7, 2023 •
edited
Loading

#152396 was merged the evening before this test started becoming flaky, so maybe that introduced the flakiness. That PR could have changed the timing of setting layer.isLoading state. I created flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1990 to test this hypothesis.

@nreese
Copy link
Contributor

nreese commented Mar 7, 2023

Confirmed, flakyness caused by #152396

flaky test runner on #152396 had 39 out of 50 failures - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1990
flaky test runner on PR prior to #152396 had 0 out of 50 failures - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1991

@nreese nreese mentioned this issue Mar 7, 2023
Merged
@Heenawter Heenawter assigned nreese and Heenawter and unassigned Heenawter Mar 7, 2023
nreese added a commit that referenced this issue Mar 9, 2023
@nreese @kibanamachine
[maps] unskip Chrome X-Pack UI Functional Tests.x-pack/test/functiona…
278796d 
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (#152850)

Fixes #152476

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995

#152396 added an await to map
loading that waits for EMS fonts HEAD request. This introduced test
flakiness. This PR resolves the issue by re-working the solution from
#152476 to not block map loading
for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts
HEAD request fails after map has loaded.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@kibanamachine @bmorelli25
skip failing test suite (elastic#152476)
c2120a5
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@nreese @kibanamachine @bmorelli25
[maps] unskip Chrome X-Pack UI Functional Tests.x-pack/test/functiona…
72dfc02 
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (elastic#152850)

Fixes elastic#152476

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995

elastic#152396 added an await to map
loading that waits for EMS fonts HEAD request. This introduced test
flakiness. This PR resolves the issue by re-working the solution from
elastic#152476 to not block map loading
for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts
HEAD request fails after map has loaded.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine reopened this Mar 29, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@Heenawter Heenawter removed their assignment Apr 4, 2023
@nreese
Copy link
Contributor

nreese commented Apr 4, 2023 •
edited
Loading

Closed by #153973. Test that failed did not have changes from #153973 merged and was still using EMS.

@nreese nreese closed this as completed Apr 4, 2023
@kibanamachine kibanamachine reopened this Sep 21, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Sep 21, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 7fab0b1

kibanamachine added a commit that referenced this issue Sep 21, 2023
@kibanamachine
skip failing test suite (#152476)
7fab0b1
@nreese nreese mentioned this issue Oct 4, 2023
Merged
nreese added a commit that referenced this issue Oct 4, 2023
@nreese
unskip Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/fu…
45f7042 
…nctional/apps/dashboard/group2/dashboard_maps_by_value·ts (#168003)

Closes #152476

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3343

Similar to #167836, test is
failing because appsMenu.clickLink is not loading dashboard (see
captured log messages from failure). Switching to
navigateToAppFromAppsMenu to include retry logic.

<img width="500" alt="Screenshot 2023-10-04 at 9 45 46 AM"
src="https://github.com/elastic/kibana/assets/373691/194c4f87-d6dd-4b59-b645-31e01776c7be">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
7 participants
@nreese @jughosta @jbudz @Heenawter @ThomThomson @elasticmachine @kibanamachine