Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Flaky test] /x-pack/plugins/security_solution/cypress/e2e/detection_alerts/detection_page_filters.cy.ts/Detections Page Filters -- Alert Page Filters Customization -- should not sync to the URL in edit mode but only in view mode #153686

Closed
Tracked by #153667
MadameSheema opened this issue Mar 24, 2023 · 2 comments
Closed
Tracked by #153667

[Security Solution][Flaky test] /x-pack/plugins/security_solution/cypress/e2e/detection_alerts/detection_page_filters.cy.ts/Detections Page Filters -- Alert Page Filters Customization -- should not sync to the URL in edit mode but only in view mode #153686

MadameSheema opened this issue Mar 24, 2023 · 2 comments
Assignees
@logeekal
Labels
fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@MadameSheema
Copy link
Member 

2) Detections : Page Filters
--
  | proc [cypress]        Alert Page Filters Customization
  | proc [cypress]          should not sync to the URL in edit mode but only in view mode:
  | proc [cypress]      AssertionError: Timed out retrying after 150000ms: Expected <div.controlFrame--controlLoading> not to exist in the DOM, but it was continuously found.
  | proc [cypress]       at Context.eval (webpack:///./tasks/alerts.ts:451:45)

Detections Page Filters -- Alert Page Filters Customization -- should not sync to the URL in edit mode but only in view mode (failed) (attempt 3)
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team labels Mar 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema mentioned this issue Mar 24, 2023
Closed
@logeekal logeekal mentioned this issue Apr 27, 2023
Merged
1 task
logeekal added a commit that referenced this issue May 2, 2023
@logeekal
[Security Solution] [Fix] Cypress test flakyness in Alert page Contro…
6203acb 
…ls (#155988)

## Summary

Handles :  #153685 and #153686

This PR tries to fix the flakyness of cypress tests. Although, this
issue in cypress is very difficult to reproduce, I noticed that it is
coming mainly when adding extra control.

And it looks like during the course of dev one of the API of adding a
control called `addOptionsListControl` was changed to be a promise,
therefore, mainly the change is to await the promise before adding a new
control.


### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
logeekal added a commit to logeekal/kibana that referenced this issue May 3, 2023
@logeekal
[Security Solution] [Fix] Cypress test flakyness in Alert page Contro…
b202b14 
…ls (elastic#155988)

## Summary

Handles :  elastic#153685 and elastic#153686

This PR tries to fix the flakyness of cypress tests. Although, this
issue in cypress is very difficult to reproduce, I noticed that it is
coming mainly when adding extra control.

And it looks like during the course of dev one of the API of adding a
control called `addOptionsListControl` was changed to be a promise,
therefore, mainly the change is to await the promise before adding a new
control.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 6203acb)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/lib/kibana/kibana_react.mock.ts
logeekal added a commit that referenced this issue May 3, 2023
@logeekal @kibanamachine
[8.8] [Security Solution] [Fix] Cypress test flakyness in Alert page …
5fb469c 
…Controls (#155988) (#156486)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] [Fix] Cypress test flakyness in Alert page
Controls (#155988)](#155988)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T17:24:11Z","message":"[Security
Solution] [Fix] Cypress test flakyness in Alert page Controls
(#155988)\n\n## Summary\r\n\r\nHandles : #153685 and #153686\r\n\r\nThis
PR tries to fix the flakyness of cypress tests. Although, this\r\nissue
in cypress is very difficult to reproduce, I noticed that it
is\r\ncoming mainly when adding extra control.\r\n\r\nAnd it looks like
during the course of dev one of the API of adding a\r\ncontrol called
`addOptionsListControl` was changed to be a promise,\r\ntherefore,
mainly the change is to await the promise before adding a
new\r\ncontrol.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that
are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"6203acbe0516fed363d99b8c7a067b57d48e5f62","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":155988,"url":"https://github.com/elastic/kibana/pull/155988","mergeCommit":{"message":"[Security
Solution] [Fix] Cypress test flakyness in Alert page Controls
(#155988)\n\n## Summary\r\n\r\nHandles : #153685 and #153686\r\n\r\nThis
PR tries to fix the flakyness of cypress tests. Although, this\r\nissue
in cypress is very difficult to reproduce, I noticed that it
is\r\ncoming mainly when adding extra control.\r\n\r\nAnd it looks like
during the course of dev one of the API of adding a\r\ncontrol called
`addOptionsListControl` was changed to be a promise,\r\ntherefore,
mainly the change is to await the promise before adding a
new\r\ncontrol.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that
are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"6203acbe0516fed363d99b8c7a067b57d48e5f62"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155988","number":155988,"mergeCommit":{"message":"[Security
Solution] [Fix] Cypress test flakyness in Alert page Controls
(#155988)\n\n## Summary\r\n\r\nHandles : #153685 and #153686\r\n\r\nThis
PR tries to fix the flakyness of cypress tests. Although, this\r\nissue
in cypress is very difficult to reproduce, I noticed that it
is\r\ncoming mainly when adding extra control.\r\n\r\nAnd it looks like
during the course of dev one of the API of adding a\r\ncontrol called
`addOptionsListControl` was changed to be a promise,\r\ntherefore,
mainly the change is to await the promise before adding a
new\r\ncontrol.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that
are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"6203acbe0516fed363d99b8c7a067b57d48e5f62"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@logeekal logeekal added the fixed label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logeekal logeekal

Labels
fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@logeekal @elasticmachine @michaelolo24 @MadameSheema