Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Selecting any Filter option in Saved Search Flyout displays success toast even when filter was not added #154993

Closed
nicpenning opened this issue Apr 16, 2023 · 2 comments · Fixed by #155645
Closed

[Dashboard] Selecting any Filter option in Saved Search Flyout displays success toast even when filter was not added #154993

nicpenning opened this issue Apr 16, 2023 · 2 comments · Fixed by #155645
Assignees
@jughosta
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@nicpenning
Copy link

nicpenning commented Apr 16, 2023 •
edited
Loading

Kibana version:
8.7.0
Elasticsearch version:
8.7.0
Server OS version:
Windows Server 2019
Browser version:
MS Edge, Latest
Browser OS version:
Latest
Original install method (e.g. download page, yum, from source, etc.):
Download Page
Describe the bug:
When you click on Filter for value, Filter out value, or Filter for value exists, then you will see a success message even though two options exist that need a confirmation before the filter can be added (Explore Underlying Data / Apply Filter to current view)
Steps to reproduce:

  1. Go to a dashboard that has a saved search with documents
    2.Open a document to view by expanding it
  2. Click on the filter options and see the toast pop up before you acknowledge your final action
    image

Expected behavior:
I would expect that the successful filter toast message won't exist until I actually filter on a value.
Screenshots (if relevant):
ezgif com-video-to-gif
@nicpenning nicpenning added the bug Fixes for quality problems that affect the customer experience label Apr 16, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 16, 2023
@nicpenning nicpenning changed the title [Discover] Selecting any Filter option in Flyout display success message even when filter was not added [Discover] Selecting any Filter option in Flyout displays success toast even when filter was not added Apr 16, 2023
@nicpenning nicpenning changed the title [Discover] Selecting any Filter option in Flyout displays success toast even when filter was not added [Saved Search] Selecting any Filter option in Flyout displays success toast even when filter was not added Apr 16, 2023
@nicpenning nicpenning changed the title [Saved Search] Selecting any Filter option in Flyout displays success toast even when filter was not added [Dashboard] Selecting any Filter option in Saved Search Flyout displays success toast even when filter was not added Apr 16, 2023
@jughosta jughosta added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 21, 2023
@davismcphee davismcphee added Feature:Discover Discover Application loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:UnifiedDocViewer Issues relating to the unified doc viewer component labels Apr 21, 2023
@jughosta jughosta mentioned this issue Apr 24, 2023
Merged
jughosta added a commit that referenced this issue Apr 26, 2023
@jughosta
[Discover] Remove redundant "Filter was added" toast (#155645)
7534cc7 
Closes #154993

## Summary

This PR removes "Filter was added" toast (it was visible after adding
filters from the Doc Viewer flyout) which was not very useful. It's also
not shown when user adds filters from the grid or sidebar.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 26, 2023
@jughosta
[Discover] Remove redundant "Filter was added" toast (elastic#155645)
5811025 
Closes elastic#154993

## Summary

This PR removes "Filter was added" toast (it was visible after adding
filters from the Doc Viewer flyout) which was not very useful. It's also
not shown when user adds filters from the grid or sidebar.

(cherry picked from commit 7534cc7)
@jughosta
Copy link
Contributor

Thanks for reporting!

@jughosta jughosta self-assigned this Apr 26, 2023
kibanamachine referenced this issue Apr 26, 2023
@kibanamachine @jughosta
[8.7] [Discover] Remove redundant "Filter was added" toast (#155645) (#…
ce77b30 
…155825)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Discover] Remove redundant "Filter was added" toast
(#155645)](#155645)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-04-26T06:30:55Z","message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or
sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.8.0"],"number":155645,"url":"https://github.com/elastic/kibana/pull/155645","mergeCommit":{"message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or
sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155645","number":155645,"mergeCommit":{"message":"[Discover]
Remove redundant \"Filter was added\" toast (#155645)\n\nCloses
https://github.com/elastic/kibana/issues/154993\r\n\r\n##
Summary\r\n\r\nThis PR removes \"Filter was added\" toast (it was
visible after adding\r\nfilters from the Doc Viewer flyout) which was
not very useful. It's also\r\nnot shown when user adds filters from the
grid or sidebar.","sha":"7534cc78511febd457b3ea1efca8b8c0057850de"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application Feature:UnifiedDocViewer Issues relating to the unified doc viewer component impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Remove redundant "Filter was added" toast jughosta/kibana
4 participants
@jughosta @nicpenning @elasticmachine @davismcphee