[Response Ops] Triggers Actions Alert table unmounts / remounts complete row when clicking on checkbox. #155229
Labels
bug
Fixes for quality problems that affect the customer experience
fixed
QA:Validated
Issue has been validated by QA
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
triage_needed
Comments
logeekal
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
logeekal
added a commit
that referenced
this issue
May 2, 2023
…+ TopN Not rendering (#155478) ## Summary This PR handles : - Column width is reset when alert table re-renders #154796 - [Response Ops] Triggers Actions Alert table un-mounts / remounts complete row when clicking on checkbox. #155229 - [Security Solution] TopN does not work on Alert Table in Event Rendered View #155152 |Before | After | |---|---| | <video src="https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov" /> | <video src="https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov" /> |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 2, 2023
…+ TopN Not rendering (elastic#155478) ## Summary This PR handles : - Column width is reset when alert table re-renders elastic#154796 - [Response Ops] Triggers Actions Alert table un-mounts / remounts complete row when clicking on checkbox. elastic#155229 - [Security Solution] TopN does not work on Alert Table in Event Rendered View elastic#155152 |Before | After | |---|---| | <video src="https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov" /> | <video src="https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov" /> | (cherry picked from commit eba1001)
kibanamachine
added a commit
that referenced
this issue
May 2, 2023
…reset + TopN Not rendering (#155478) (#156411) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)](#155478) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:22:26Z","message":"[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column width is reset when alert table re-renders #154796 \r\n- [Response Ops] Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when clicking on checkbox. #155229\r\n- [Security Solution] TopN does not work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n |","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Threat Hunting:Investigations","v8.8.0","v8.9.0"],"number":155478,"url":"https://github.com/elastic/kibana/pull/155478","mergeCommit":{"message":"[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column width is reset when alert table re-renders #154796 \r\n- [Response Ops] Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when clicking on checkbox. #155229\r\n- [Security Solution] TopN does not work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n |","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155478","number":155478,"mergeCommit":{"message":"[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column width is reset when alert table re-renders #154796 \r\n- [Response Ops] Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when clicking on checkbox. #155229\r\n- [Security Solution] TopN does not work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n |","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
|
@karanbirsingh-qasource @sukhwindersingh-qasource please validate the fix on BC2 for Security Solution. Thanks! |
|
We have validated this issue on 8.8 BC2 and found the issue to be fixed ✔️ . Build Details: Screen-Cast Alerts.-.Kibana.Mozilla.Firefox.2023-05-08.13-16-03.mp4Hence we are Closing this issue and adding "QA:Source" tag to it. thanks !! |
ghost
closed this as This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
Triggers Actions Alert table unmounts / remounts complete row when clicking on checkbox.
Ideally, only checkbox column should be re-rendered but currrenty, table is rebuilding the row from scratch and because of it there is flicker visible in the row when it has a bigger height.
Please see the below video examples from o11y and Security solution.
o11y Example
The change is not visually visible in o11y so I applied some styles to the content and On clicking the checkbox, you can see that styles are gone and the content was remounted. This happens irrespective of what the content is.
o11y.issue.mov
Issue - Security Solution example
The issue is clearly visible when row has a substantial height.
Screen.Recording.2023-04-19.at.10.07.01.mov
Security Solution No issue
We are using
EuiDataGridat other places in Security solution and same issue does not occur there. So it is notEuiDataGridissue. Please see the video belowScreen.Recording.2023-04-19.at.10.12.40.mov
This also leads to slow perceived performance of alert table.
Kibana/Elasticsearch Stack version:
8.8
Server OS version:
Macos
Browser and Browser OS versions:
Elastic Endpoint version:
Not relevant
Original install method (e.g. download page, yum, from source, etc.):
Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Steps to reproduce:
Current behavior:
Whole row is re-remounted when checkbox is clicked.
Expected behavior:
Whole should not re-mounted when checkbox is clicked.
Screenshots (if relevant):
Errors in browser console (if relevant):
Provide logs and/or server output (if relevant):
Any additional context (logs, chat logs, magical formulas, etc.):
The text was updated successfully, but these errors were encountered: