Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Files] Expose bulk get files API from the files service on the backend #155369

Closed
cnasikas opened this issue Apr 20, 2023 · 2 comments · Fixed by #155636
Closed

[Files] Expose bulk get files API from the files service on the backend #155369

cnasikas opened this issue Apr 20, 2023 · 2 comments · Fixed by #155636
Assignees
@vadimkibana
Labels
Feature:Cases Cases feature feature:Files NeededFor:ResponseOps Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@cnasikas
Copy link
Member

In 8.8 we added the ability to attach files to a case. When a user deletes a case we delete all files associated with this case. To perform authorization checks on the files, we get all files (saved objects) attached to the case before deleting the case and the files. The file service does not expose a bulk get operation so we have to get all files one by one. To improve the performance of our API it would be useful to have a bulk get API exposed from the file service.
@cnasikas cnasikas added Feature:Cases Cases feature Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) feature:Files NeededFor:ResponseOps labels Apr 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas changed the title [File Service] Expose bulk get files API from the files service on the backend [Files] Expose bulk get files API from the files service on the backend Apr 20, 2023
@vadimkibana vadimkibana mentioned this issue Apr 24, 2023
Merged
2 tasks
@vadimkibana vadimkibana self-assigned this Apr 24, 2023
vadimkibana added a commit that referenced this issue Apr 27, 2023
@vadimkibana @kibanamachine
[Files] Adds bulk get method (#155636)
a0cd724 
## Summary

Closes #155369


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 27, 2023
@vadimkibana
[Files] Adds bulk get method (elastic#155636)
a346dbe 
## Summary

Closes elastic#155369

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a0cd724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkibana vadimkibana

Labels
Feature:Cases Cases feature feature:Files NeededFor:ResponseOps Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Files] Adds bulk get method vadimkibana/kibana
3 participants
@cnasikas @elasticmachine @vadimkibana