[Security Solution] Fix a broken UI on the rule details page #155596
Assignees
Labels
8.8 candidate
bug
Fixes for quality problems that affect the customer experience
Feature:Rule Management
Security Solution Detection Rule Management
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Team:Detection Rule Management
Security Detection Rule Management Team
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.8.0
Comments
maximpn
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
2 tasks
banderror
added
impact:high
4 tasks
maximpn
added a commit
that referenced
this issue
May 4, 2023
**Resolves:** #155596 ## Summary It fixes a broken header on small screen after adding rule snooze badge component. *Before:*    *After:*    ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 4, 2023
) **Resolves:** elastic#155596 ## Summary It fixes a broken header on small screen after adding rule snooze badge component. *Before:*    *After:*    ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 0a9bbe7)
kibanamachine
referenced
this issue
May 4, 2023
…) (#156650) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Fix a broken header on small screens (#156525)](#156525) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T08:19:36Z","message":"[Security Solution] Fix a broken header on small screens (#156525)\n\n**Resolves:** https://github.com/elastic/kibana/issues/155596\r\n\r\n## Summary\r\n\r\nIt fixes a broken header on small screen after adding rule snooze badge component. \r\n\r\n*Before:*\r\n\r\n\r\n\r\n\r\n\r\n*After:*\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"0a9bbe7c1fd32765116f508b9d01879ba58482fb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rules","backport:prev-minor","v8.8.0","v8.9.0"],"number":156525,"url":"https://github.com/elastic/kibana/pull/156525","mergeCommit":{"message":"[Security Solution] Fix a broken header on small screens (#156525)\n\n**Resolves:** https://github.com/elastic/kibana/issues/155596\r\n\r\n## Summary\r\n\r\nIt fixes a broken header on small screen after adding rule snooze badge component. \r\n\r\n*Before:*\r\n\r\n\r\n\r\n\r\n\r\n*After:*\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"0a9bbe7c1fd32765116f508b9d01879ba58482fb"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156525","number":156525,"mergeCommit":{"message":"[Security Solution] Fix a broken header on small screens (#156525)\n\n**Resolves:** https://github.com/elastic/kibana/issues/155596\r\n\r\n## Summary\r\n\r\nIt fixes a broken header on small screen after adding rule snooze badge component. \r\n\r\n*Before:*\r\n\r\n\r\n\r\n\r\n\r\n*After:*\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"0a9bbe7c1fd32765116f508b9d01879ba58482fb"}}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
\r\n\r\n\r\n*After:*\r\n\r\n\r\n\r\n\r\n\r\n\r\n###](https://user-images.githubusercontent.com/3775283/235914975-d30c75c4-f4fe-4887-86d1-417787e16521.png)\r\n\r\n\r\n\r\n*After:*\r\n\r\n\r\n\r\n\r\n\r\n\r\n###){kind=link}
|
The bug was fixed by #156525 and backported to 8.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Relates to: https://github.com/elastic/security-team/issues/5308
Summary
The layout on smaller screens becomes broken on the rule details page after adding rule snoozing component.
The text was updated successfully, but these errors were encountered: