Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tsconfigs for test and build #15575

Closed
kimjoar opened this issue Dec 13, 2017 · 2 comments
Closed

Separate tsconfigs for test and build #15575

kimjoar opened this issue Dec 13, 2017 · 2 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kimjoar
Copy link
Contributor

kimjoar commented Dec 13, 2017

As we want to use TypeScript in tests too, we can't exclude **/__tests__/** files from our production builds. The usual approach seems to be having the default tsconfig for a package include all files, then exclude tests in a separate tsconfig (and then specify --project to have it use that tsconfig when building the code).

@kimjoar kimjoar added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 13, 2017
@kimjoar
Copy link
Contributor Author

kimjoar commented Jan 19, 2018

This will likely get handled in the build system itself. I'll be writing up a larger issue on this stuff.

@epixa
Copy link
Contributor

epixa commented May 5, 2018

Closing in favor of #18780

@epixa epixa closed this as completed May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants