Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ts for tests #15576

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Run ts for tests #15576

merged 1 commit into from
Dec 13, 2017

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Dec 13, 2017

Stopped excluding the tests files from the tsconfigs, which caught a couple problems in the tests. I created #15575 for finding a better approach.

@kimjoar kimjoar requested a review from rhoboat December 13, 2017 13:18
@kimjoar kimjoar mentioned this pull request Dec 13, 2017
Merged
3 tasks
rhoboat
rhoboat approved these changes Dec 13, 2017
View reviewed changes
Copy link

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this out on my vim setup and also rebased a WIP PR over it to see the effects.

@kimjoar kimjoar merged commit a55ba1f into new-platform Dec 13, 2017
@spalger spalger deleted the platform/run-ts-for-tests branch May 2, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhoboat rhoboat rhoboat approved these changes

Assignees
No one assigned
Labels
Feature:New Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimjoar @rhoboat