-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Viewer user - Tooltip content for monitor status rule is different from other tooltip content #155936
Labels
Comments
dominiqueclarke
added
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.8.0
labels
Apr 26, 2023
Pinging @elastic/uptime (Team:uptime) |
dominiqueclarke
added a commit
that referenced
this issue
May 2, 2023
## Summary Resolves #155936 Relates to #152915 Resolves #150944 Resolves #156166 Copy fixes: - Alerting config: Address Typo (#152915 (comment)) - Alerting config: Address success toast wording - Getting started ("Create your first monitor") locations: Repeated text between placeholder and hint text. To address this, I changed the helptext to give more detail - Private locations -> "Monitors" column: replaced `Running` with `configured` - Overview page: Search bar placeholder: `url` is now uppercase `URL` - Monitor status alert - Updates text for viewer user to be consistent with other tooltips - Run once errors - Remove extra error toast - Run once errors - Remove excess phrase from error - Sync errors - Made content more user friendly - Synthetics App - replace references to Monitor Management with Synthetics App - Enable/disable - clarify when actions apply to all monitors - Project monitors - add reference to enabling/disabling alerting on project monitor page - Enablement - Adjust content for less privileged users Some screenshots of the fixes are below. These are not exhaustive <img width="1417" alt="Screen Shot 2023-04-25 at 12 12 38 PM" src="https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png"> <img width="772" alt="Screen Shot 2023-04-25 at 12 12 31 PM" src="https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png"> <img width="909" alt="Screen Shot 2023-04-25 at 12 12 10 PM" src="https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png"> <img width="1414" alt="Screen Shot 2023-04-25 at 11 59 57 AM" src="https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png"> <img width="623" alt="Screen Shot 2023-04-25 at 11 57 53 AM" src="https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png"> <img width="735" alt="Screen Shot 2023-04-27 at 4 16 17 PM" src="https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png"> <img width="1240" alt="Screen Shot 2023-04-28 at 2 09 29 PM" src="https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png"> <img width="602" alt="Screen Shot 2023-04-28 at 11 12 49 AM" src="https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png"> <img width="552" alt="Screen Shot 2023-04-28 at 11 12 25 AM" src="https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png"> <img width="1448" alt="Screen Shot 2023-04-28 at 2 56 58 PM" src="https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png"> --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 2, 2023
## Summary Resolves elastic#155936 Relates to elastic#152915 Resolves elastic#150944 Resolves elastic#156166 Copy fixes: - Alerting config: Address Typo (elastic#152915 (comment)) - Alerting config: Address success toast wording - Getting started ("Create your first monitor") locations: Repeated text between placeholder and hint text. To address this, I changed the helptext to give more detail - Private locations -> "Monitors" column: replaced `Running` with `configured` - Overview page: Search bar placeholder: `url` is now uppercase `URL` - Monitor status alert - Updates text for viewer user to be consistent with other tooltips - Run once errors - Remove extra error toast - Run once errors - Remove excess phrase from error - Sync errors - Made content more user friendly - Synthetics App - replace references to Monitor Management with Synthetics App - Enable/disable - clarify when actions apply to all monitors - Project monitors - add reference to enabling/disabling alerting on project monitor page - Enablement - Adjust content for less privileged users Some screenshots of the fixes are below. These are not exhaustive <img width="1417" alt="Screen Shot 2023-04-25 at 12 12 38 PM" src="https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png"> <img width="772" alt="Screen Shot 2023-04-25 at 12 12 31 PM" src="https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png"> <img width="909" alt="Screen Shot 2023-04-25 at 12 12 10 PM" src="https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png"> <img width="1414" alt="Screen Shot 2023-04-25 at 11 59 57 AM" src="https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png"> <img width="623" alt="Screen Shot 2023-04-25 at 11 57 53 AM" src="https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png"> <img width="735" alt="Screen Shot 2023-04-27 at 4 16 17 PM" src="https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png"> <img width="1240" alt="Screen Shot 2023-04-28 at 2 09 29 PM" src="https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png"> <img width="602" alt="Screen Shot 2023-04-28 at 11 12 49 AM" src="https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png"> <img width="552" alt="Screen Shot 2023-04-28 at 11 12 25 AM" src="https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png"> <img width="1448" alt="Screen Shot 2023-04-28 at 2 56 58 PM" src="https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png"> --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 589ea3a)
kibanamachine
referenced
this issue
May 2, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Adjust content (#156029)](#156029) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T21:23:04Z","message":"[Synthetics] Adjust content (#156029)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/155936\r\nRelates to https://github.com/elastic/kibana/issues/152915\r\nResolves https://github.com/elastic/kibana/issues/150944\r\nResolves https://github.com/elastic/kibana/issues/156166\r\n\r\nCopy fixes:\r\n\r\n- Alerting config: Address Typo\r\n(https://github.com/elastic/kibana/issues/152915#issuecomment-1516614675)\r\n- Alerting config: Address success toast wording\r\n- Getting started (\"Create your first monitor\") locations: Repeated text\r\nbetween placeholder and hint text. To address this, I changed the\r\nhelptext to give more detail\r\n- Private locations -> \"Monitors\" column: replaced `Running` with\r\n`configured`\r\n- Overview page: Search bar placeholder: `url` is now uppercase `URL`\r\n- Monitor status alert - Updates text for viewer user to be consistent\r\nwith other tooltips\r\n- Run once errors - Remove extra error toast \r\n- Run once errors - Remove excess phrase from error\r\n- Sync errors - Made content more user friendly\r\n- Synthetics App - replace references to Monitor Management with\r\nSynthetics App\r\n- Enable/disable - clarify when actions apply to all monitors\r\n- Project monitors - add reference to enabling/disabling alerting on\r\nproject monitor page\r\n- Enablement - Adjust content for less privileged users\r\n\r\nSome screenshots of the fixes are below. These are not exhaustive\r\n<img width=\"1417\" alt=\"Screen Shot 2023-04-25 at 12 12 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img width=\"772\" alt=\"Screen Shot 2023-04-25 at 12 12 31 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img width=\"909\" alt=\"Screen Shot 2023-04-25 at 12 12 10 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img width=\"1414\" alt=\"Screen Shot 2023-04-25 at 11 59 57 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img width=\"623\" alt=\"Screen Shot 2023-04-25 at 11 57 53 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img width=\"735\" alt=\"Screen Shot 2023-04-27 at 4 16 17 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img width=\"1240\" alt=\"Screen Shot 2023-04-28 at 2 09 29 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img width=\"602\" alt=\"Screen Shot 2023-04-28 at 11 12 49 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img width=\"552\" alt=\"Screen Shot 2023-04-28 at 11 12 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img width=\"1448\" alt=\"Screen Shot 2023-04-28 at 2 56 58 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <florent.leborgne@elastic.co>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"589ea3affc6c64ef69c81bc01da767388b246dc9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","Team:Fleet","v8.8.0","v8.9.0"],"number":156029,"url":"https://github.com/elastic/kibana/pull/156029","mergeCommit":{"message":"[Synthetics] Adjust content (#156029)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/155936\r\nRelates to https://github.com/elastic/kibana/issues/152915\r\nResolves https://github.com/elastic/kibana/issues/150944\r\nResolves https://github.com/elastic/kibana/issues/156166\r\n\r\nCopy fixes:\r\n\r\n- Alerting config: Address Typo\r\n(https://github.com/elastic/kibana/issues/152915#issuecomment-1516614675)\r\n- Alerting config: Address success toast wording\r\n- Getting started (\"Create your first monitor\") locations: Repeated text\r\nbetween placeholder and hint text. To address this, I changed the\r\nhelptext to give more detail\r\n- Private locations -> \"Monitors\" column: replaced `Running` with\r\n`configured`\r\n- Overview page: Search bar placeholder: `url` is now uppercase `URL`\r\n- Monitor status alert - Updates text for viewer user to be consistent\r\nwith other tooltips\r\n- Run once errors - Remove extra error toast \r\n- Run once errors - Remove excess phrase from error\r\n- Sync errors - Made content more user friendly\r\n- Synthetics App - replace references to Monitor Management with\r\nSynthetics App\r\n- Enable/disable - clarify when actions apply to all monitors\r\n- Project monitors - add reference to enabling/disabling alerting on\r\nproject monitor page\r\n- Enablement - Adjust content for less privileged users\r\n\r\nSome screenshots of the fixes are below. These are not exhaustive\r\n<img width=\"1417\" alt=\"Screen Shot 2023-04-25 at 12 12 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img width=\"772\" alt=\"Screen Shot 2023-04-25 at 12 12 31 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img width=\"909\" alt=\"Screen Shot 2023-04-25 at 12 12 10 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img width=\"1414\" alt=\"Screen Shot 2023-04-25 at 11 59 57 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img width=\"623\" alt=\"Screen Shot 2023-04-25 at 11 57 53 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img width=\"735\" alt=\"Screen Shot 2023-04-27 at 4 16 17 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img width=\"1240\" alt=\"Screen Shot 2023-04-28 at 2 09 29 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img width=\"602\" alt=\"Screen Shot 2023-04-28 at 11 12 49 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img width=\"552\" alt=\"Screen Shot 2023-04-28 at 11 12 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img width=\"1448\" alt=\"Screen Shot 2023-04-28 at 2 56 58 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <florent.leborgne@elastic.co>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"589ea3affc6c64ef69c81bc01da767388b246dc9"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156029","number":156029,"mergeCommit":{"message":"[Synthetics] Adjust content (#156029)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/155936\r\nRelates to https://github.com/elastic/kibana/issues/152915\r\nResolves https://github.com/elastic/kibana/issues/150944\r\nResolves https://github.com/elastic/kibana/issues/156166\r\n\r\nCopy fixes:\r\n\r\n- Alerting config: Address Typo\r\n(https://github.com/elastic/kibana/issues/152915#issuecomment-1516614675)\r\n- Alerting config: Address success toast wording\r\n- Getting started (\"Create your first monitor\") locations: Repeated text\r\nbetween placeholder and hint text. To address this, I changed the\r\nhelptext to give more detail\r\n- Private locations -> \"Monitors\" column: replaced `Running` with\r\n`configured`\r\n- Overview page: Search bar placeholder: `url` is now uppercase `URL`\r\n- Monitor status alert - Updates text for viewer user to be consistent\r\nwith other tooltips\r\n- Run once errors - Remove extra error toast \r\n- Run once errors - Remove excess phrase from error\r\n- Sync errors - Made content more user friendly\r\n- Synthetics App - replace references to Monitor Management with\r\nSynthetics App\r\n- Enable/disable - clarify when actions apply to all monitors\r\n- Project monitors - add reference to enabling/disabling alerting on\r\nproject monitor page\r\n- Enablement - Adjust content for less privileged users\r\n\r\nSome screenshots of the fixes are below. These are not exhaustive\r\n<img width=\"1417\" alt=\"Screen Shot 2023-04-25 at 12 12 38 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906460-529d48d4-f682-4d45-b439-7bd7189c37ea.png\">\r\n<img width=\"772\" alt=\"Screen Shot 2023-04-25 at 12 12 31 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906462-b85d6fe0-2d32-42f0-81fb-2f528c5c0d87.png\">\r\n<img width=\"909\" alt=\"Screen Shot 2023-04-25 at 12 12 10 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906466-49286af9-29c4-4bcb-9d10-dc84bcddd66f.png\">\r\n<img width=\"1414\" alt=\"Screen Shot 2023-04-25 at 11 59 57 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906468-48b27002-5771-42df-9ee5-5852dabeaaeb.png\">\r\n<img width=\"623\" alt=\"Screen Shot 2023-04-25 at 11 57 53 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234906470-4ea5acf7-bff2-41af-a679-7e4b9f43c377.png\">\r\n<img width=\"735\" alt=\"Screen Shot 2023-04-27 at 4 16 17 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/234982914-128af18e-204a-4df6-a791-ac3155d8b5b9.png\">\r\n<img width=\"1240\" alt=\"Screen Shot 2023-04-28 at 2 09 29 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223171-f2177983-f8cc-45a3-8ff8-76850508e63e.png\">\r\n<img width=\"602\" alt=\"Screen Shot 2023-04-28 at 11 12 49 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223288-7b01dd85-2311-4b42-bb91-92e4a4f454e3.png\">\r\n<img width=\"552\" alt=\"Screen Shot 2023-04-28 at 11 12 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235223290-00cc6a8c-7f9c-46f1-b8ae-5c98eaeaa35d.png\">\r\n<img width=\"1448\" alt=\"Screen Shot 2023-04-28 at 2 56 58 PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/235230906-093d720c-9ac9-4cf1-b04a-34a1409d7379.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: florent-leborgne <florent.leborgne@elastic.co>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"589ea3affc6c64ef69c81bc01da767388b246dc9"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
POST FF Testing looks good !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Kibana version: 8.8.0
Description of the problem including expected versus actual behavior:
The tooltip content on the monitor status rule is different from tooltip content elsewhere. We should make the content consistent.
Monitor status content
All other content
Steps to reproduce:
viewer
roleThe text was updated successfully, but these errors were encountered: