Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram + Lines incorrectly graphs points with no data #159

Closed
gladed opened this issue Jun 12, 2013 · 6 comments · Fixed by #400
Closed

Histogram + Lines incorrectly graphs points with no data #159

gladed opened this issue Jun 12, 2013 · 6 comments · Fixed by #400
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@gladed
Copy link

gladed commented Jun 12, 2013

If you have a histogram with a series, and one of the series has missing data points, they are not graphed as "0" -- instead they are graphed as a line between two data points that are present. This is not appropriate for a histogram showing counts over time as it implies there are counts where there aren't any.

(See the yellow line in the graph below.)

straight line

@rashidkpc
Copy link
Contributor

You are absolutely correct, this needs to be fixed

@gladed
Copy link
Author

gladed commented Jun 12, 2013

CanI help? Point me at the right code...

@caspergasper
Copy link

Shouldn't this be marked as a bug? If you use stack mode on your graphs and the bottom-most option has no data there is nothing displayed.

@rashidkpc
Copy link
Contributor

Yes, this is a bug, it would require 0 filling the series. It need to be fixed.

@nikicat
Copy link

nikicat commented Aug 15, 2013

+1

@olej-a
Copy link

olej-a commented Aug 16, 2013

olej-a@63be4e7

@ghost ghost assigned spalger Aug 20, 2013
spalger pushed a commit that referenced this issue Oct 6, 2014
spalger pushed a commit that referenced this issue Oct 6, 2014
w33ble added a commit to w33ble/kibana that referenced this issue Sep 13, 2018
* feat: opt in to series style arguments

because not all element types will have all of the series types, turn the included fields into an option so that they can opt in

* feat: add seriesStyle arg to pie function

* fix: default series style value is null

otherwise users have to pick a different value in order to select the first one and set it in the expression

* chore: refactor the grid function and element

in preparation for adding series style, make some of the code a little
more concise. this was also an execise in understanding how it all
works.

* feat: add seriesStyle to grid function

append a style property to each of the marks in the cells

* feat: add seriesStyle as expression arg

and resolve the labels for the series

* feat: make grid element render with series style

* fix: hide expanded section when converting arg input

when going from the fallback textarea input to a simple form, the expanded form wasn't being hidden

* fix: don't render plot property inputs

when a seriesStyle arg is configured without plot styles, don't render the form container for them

* fix: bug when getting a named value from collections

when the property doesn't exist on the objects in the collection, the result was an array with undefined value. by filtering out undefine, this won't happen anymore

* feat: show warning on series style

if the data model doesn't include a color property, then show a warning tooltip telling the user to add one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants