Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared UX] Migrate all usages of EuiPage*_Deprecated #161422

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 2 comments · Fixed by #166225
Closed
Tracked by #161872

[Shared UX] Migrate all usages of EuiPage*_Deprecated #161422

cee-chen opened this issue Jul 7, 2023 · 2 comments · Fixed by #166225
Assignees
@vadimkibana
Labels
deprecation_warnings EUI Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 7, 2023 •
edited by vadimkibana
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added the EUI label Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@petrklapka petrklapka assigned petrklapka and unassigned petrklapka Jul 18, 2023
@vadimkibana vadimkibana self-assigned this Aug 3, 2023
This was referenced Aug 9, 2023
Merged
Merged
Merged
Merged
vadimkibana added a commit that referenced this issue Aug 10, 2023
@vadimkibana @kibanamachine
Rm canvas deprecations (#163467)
2113878 
## Summary

Substitutes deprecated components from `kibana_react` plugin in Canvas
app by latest ones from packages.

Partially addresses #161422

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
vadimkibana added a commit that referenced this issue Aug 10, 2023
@vadimkibana
Update EUI layout components in dev examples (#163494)
8e94530 
## Summary

Partially addresses #161422

New look of developer examples:

<img width="1231" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/15a3b31d-4f0c-4508-afa7-cb02e00f6b53">
vadimkibana added a commit that referenced this issue Aug 10, 2023
@vadimkibana @kibanamachine
Update EUI layout components in bfetch example plugin (#163490)
8e63cd9 
## Summary

Partially addresses #161422

New look:

<img width="1756" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/22ca2936-1a5f-4913-b832-0c5a4e037b08">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
vadimkibana added a commit that referenced this issue Aug 14, 2023
@vadimkibana @kibanamachine
Update usage of deprecated EUI components in SharedUx plugins (#163560)
cc8e8fe 
## Summary

Partially addresses #161422

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Aug 16, 2023
Merged
Merged
vadimkibana added a commit that referenced this issue Aug 17, 2023
@vadimkibana @kibanamachine
update deprecated eui components in reportin_example plugin (#164071)
2f79a62 
## Summary

Partially addresses #161422

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
vadimkibana added a commit that referenced this issue Aug 17, 2023
@vadimkibana
Eui deprecations 5 (#164106)
3d60f22 
## Summary

Partially addresses #161422
@vadimkibana vadimkibana mentioned this issue Sep 7, 2023
Merged
vadimkibana added a commit that referenced this issue Sep 11, 2023
@vadimkibana @kibanamachine
Update eui deprecated components in screenshotting plugin (#164068)
e72780a 
## Summary

Partially addresses #161422

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Sep 12, 2023
Merged
Merged
vadimkibana added a commit that referenced this issue Sep 14, 2023
@vadimkibana @kibanamachine
Remove deprecated EUI components in reporting_example plugin (#166224)
19235fa 
## Summary

Partially addresses #161422

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
vadimkibana added a commit that referenced this issue Sep 25, 2023
@vadimkibana @kibanamachine
Remove deprecated EUI components in kibana_react (#166225)
dfcf60a 
## Summary

Closes #161422

In this PR:

- [x] Removes `KibanaPageTemplate` utilities from `kibana_react`
- [x] Migrates remaining users of `KibanaPageTemplate` from
`kibana_react` to the one from `@kbn/shared-ux-page-kibana-template`
- [x]
`src/plugins/home/public/application/components/tutorial_directory.js`
- [x]
`src/plugins/home/public/application/components/tutorial/tutorial.js`
  - [x] `x-pack/plugins/osquery/public/components/empty_state.tsx`

## Visual Changes

Below are the main visual differences this PR introduces.

Sample data page before:

<img width="1419" alt="Screenshot 2023-09-13 at 12 12 11"
src="https://github.com/elastic/kibana/assets/82822460/cbad5bd2-9c51-486c-a48d-ac44a80cdbf7">

Sample data page now:

<img width="1456" alt="Screenshot 2023-09-13 at 12 12 18"
src="https://github.com/elastic/kibana/assets/82822460/4118db78-89e8-41ed-a3d3-51a221dde857">

Tutorials page before:

<img width="1402" alt="Screenshot 2023-09-13 at 13 09 58"
src="https://github.com/elastic/kibana/assets/82822460/b51af548-211a-4a59-9143-b82f2ff55678">

Tutorials page now:

<img width="1439" alt="Screenshot 2023-09-13 at 13 10 04"
src="https://github.com/elastic/kibana/assets/82822460/f71590a3-7c3d-4f60-a460-47aacdfcbf09">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkibana vadimkibana

Labels
deprecation_warnings EUI Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated EUI components in kibana_react vadimkibana/kibana
4 participants
@cee-chen @elasticmachine @petrklapka @vadimkibana