Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Migrate all usages of EuiPage*_Deprecated #161424

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #161548
Closed
Tracked by #161872

[Core] Migrate all usages of EuiPage*_Deprecated #161424

cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #161548
Assignees
@pgayvallet
Labels
deprecation_warnings EUI Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 7, 2023

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!
@cee-chen cee-chen added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc deprecation_warnings EUI labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@pgayvallet pgayvallet self-assigned this Jul 10, 2023
@pgayvallet pgayvallet mentioned this issue Jul 10, 2023
Merged
pgayvallet added a commit that referenced this issue Jul 13, 2023
@pgayvallet @kibanamachine
Migrate from deprecated EUI components (#161548)
808c28d 
## Summary

Fix #161424

Migrate away from deprecated EUI components for Core-owned code.

Note: I only tested the production (and examples) pages properly, I
didn't make sure the test plugins where displayed correctly, as long as
the data structure was still here for the tests to pass.

### Screenshots

#### Status page

<img width="1388" alt="Screenshot 2023-07-10 at 17 14 24" 

src="https://github.com/elastic/kibana/assets/1532934/d15adffa-d4fb-4dab-ad91-691a4c103541">

#### AppNotFound page

<img width="1352" alt="Screenshot 2023-07-10 at 17 14 40"
src="https://github.com/elastic/kibana/assets/1532934/77dcc958-db53-4ec8-9a7f-af4ea0804a96">

#### Generated plugin landing page

<img width="1906" alt="Screenshot 2023-07-10 at 17 15 44"
src="https://github.com/elastic/kibana/assets/1532934/7a45d1a3-181d-44c5-a4a1-d3bdb2ba6ee9">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@cee-chen
Copy link
Member Author

Thanks for grabbing this so quickly @pgayvallet - y'all rock! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
deprecation_warnings EUI Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from deprecated EUI components pgayvallet/kibana
3 participants
@cee-chen @pgayvallet @elasticmachine