Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CM] Migrate SavedObectsFinder to CM mSearch #161545

Closed
6 of 7 tasks
Dosant opened this issue Jul 10, 2023 · 1 comment · Fixed by #162904
Closed
6 of 7 tasks

[CM] Migrate SavedObectsFinder to CM mSearch #161545

Dosant opened this issue Jul 10, 2023 · 1 comment · Fixed by #162904
Assignees
@Dosant
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 10, 2023 •
edited by davismcphee
Loading

This is a follow up to #152224

Need to migrate https://github.com/elastic/kibana/tree/main/src/plugins/saved_objects_finder to CM mSearch to make it BWC compliant as currently it directly returns saved objects:

kibana/src/plugins/saved_objects_finder/server/routes/find.ts

Line 54 in b641a22

saved_objects: savedObjects,

The tech doc for this: https://docs.google.com/document/d/1ssYmqSEUPrsuCR4iz8DohkEWekoYrm2yL4QR_fVxXLg/edit#heading=h.6sj4n6bjcgp5

blocked on AppEx saved object type migrated to CM
@Dosant to check if content types have any issues:

  • search - all good
  • map - all good
  • index-pattern - all good
  • visualization- need to add mSearch config cc @elastic/kibana-visualizations
  • visualization - fix regular search so that it doesn't implicitly search over lens and maps, migrate visualize listing page to use mSearch cc @elastic/kibana-visualizations
  • lens - need to add mSearch config cc @elastic/kibana-visualizations
  • event-annotation-group - need to add mSearch config @elastic/kibana-visualizations

cc @thomasneirynck
@Dosant Dosant self-assigned this Jul 10, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 10, 2023
@Dosant Dosant added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Jul 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 10, 2023
@Dosant Dosant mentioned this issue Jul 19, 2023
Closed
9 tasks
@mattkime mattkime mentioned this issue Jul 25, 2023
Merged
mattkime added a commit that referenced this issue Jul 26, 2023
@mattkime @kibanamachine @stratoula
Add content management mSearch to viz, lens, and event annotation gro…
0f88961 
…up (#162450)

## Summary

Adds content management api mSearch functionality to `lens`,
`visualization`, and `event_annotation_group` types via abstracted
function and types.

Part of #161545

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@mattkime @kibanamachine @stratoula
Add content management mSearch to viz, lens, and event annotation gro…
b271eac 
…up (elastic#162450)

## Summary

Adds content management api mSearch functionality to `lens`,
`visualization`, and `event_annotation_group` types via abstracted
function and types.

Part of elastic#161545

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This was referenced Aug 2, 2023
Merged
Closed
@stratoula stratoula mentioned this issue Aug 7, 2023
Closed
Dosant added a commit that referenced this issue Aug 8, 2023
@Dosant
Make SavedObjectFinder backward compatible (#162904)
304cb25 
## Summary

close #161545
close #153257

This PR makes `SavedObjectFinder` component backward compatible. It is
achieved by going through content- management layer, more technical
details
[here](https://docs.google.com/document/d/1ssYmqSEUPrsuCR4iz8DohkEWekoYrm2yL4QR_fVxXLg/edit)

### Testing

`SavedObjectFinder` is this component that allows to pick a saved object
(supports: `search` `index-pattern` `map` `visualization` `lens`
`event-annotation-group`:

![Screenshot 2023-08-07 at 16 53
32](https://github.com/elastic/kibana/assets/7784120/5c283ea5-3682-4dc8-a8ff-422e6f4f3195)


It is used in the following places: 

- Dashboard 
  - Add panel
  - Replace panel 
- Discover - Open Search 
- Visualization - Select search as a source for new viz
- Graph - select source
- Cases - markdown editor add lens 
- ML (3 places) 
- Canvas - select embeddable panel 
- Transform 
- Lens > select event annotation 




### Risks / Follow up 

The `SavedObjectFinder` should stay mostly the same, the only notable
functional change is that now `SavedObjectFinder` doesn't support
`includeFields` which allowed partial saved object returns, this was
done to make the call backward-compatible without making the system even
more complicated as otherwise we'll need a way to abstract
`includeFields` from so attributes and allow to run migrations on it
before making a search. follow up issue to bring it back
#163043

The risk with that is that some client that have a lot of large objects
might run into performance issues when using `SavedObjectFinder`. This
can be mitigated by changing listing limit in advanced setting from
default 1000 to something lower
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@Dosant @bryce-b
Make SavedObjectFinder backward compatible (elastic#162904)
9a908c7 
## Summary

close elastic#161545
close elastic#153257

This PR makes `SavedObjectFinder` component backward compatible. It is
achieved by going through content- management layer, more technical
details
[here](https://docs.google.com/document/d/1ssYmqSEUPrsuCR4iz8DohkEWekoYrm2yL4QR_fVxXLg/edit)

### Testing

`SavedObjectFinder` is this component that allows to pick a saved object
(supports: `search` `index-pattern` `map` `visualization` `lens`
`event-annotation-group`:

![Screenshot 2023-08-07 at 16 53
32](https://github.com/elastic/kibana/assets/7784120/5c283ea5-3682-4dc8-a8ff-422e6f4f3195)


It is used in the following places: 

- Dashboard 
  - Add panel
  - Replace panel 
- Discover - Open Search 
- Visualization - Select search as a source for new viz
- Graph - select source
- Cases - markdown editor add lens 
- ML (3 places) 
- Canvas - select embeddable panel 
- Transform 
- Lens > select event annotation 




### Risks / Follow up 

The `SavedObjectFinder` should stay mostly the same, the only notable
functional change is that now `SavedObjectFinder` doesn't support
`includeFields` which allowed partial saved object returns, this was
done to make the call backward-compatible without making the system even
more complicated as otherwise we'll need a way to abstract
`includeFields` from so attributes and allow to run migrations on it
before making a search. follow up issue to bring it back
elastic#163043

The risk with that is that some client that have a lot of large objects
might run into performance issues when using `SavedObjectFinder`. This
can be mitigated by changing listing limit in advanced setting from
default 1000 to something lower
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SavedObjectFinder backward compatible Dosant/kibana
2 participants
@Dosant @elasticmachine