Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vega vis needs to have visible fonts for dark theme dashboard #16456

Closed
bhavyarm opened this issue Feb 1, 2018 · 2 comments · Fixed by #73675
Closed

Vega vis needs to have visible fonts for dark theme dashboard #16456

bhavyarm opened this issue Feb 1, 2018 · 2 comments · Fixed by #73675
Assignees
@VladLasitsa
Labels
bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Feb 1, 2018

Kibana version: 6.3.0 BC4

Elasticsearch version: 6.3.0 BC4

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Description of the problem including expected versus actual behavior: If you change the theme of dashboard to dark theme - the fonts in vega vizs are not visible.

cc @nyurik

vega_viz
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Feb 1, 2018
@nyurik nyurik added the Feature:Vega Vega visualizations label Feb 1, 2018
@timroes
Copy link
Contributor

timroes commented Mar 21, 2018

Since Vega needs to know about light/dark color scheme in code, we need to figure out the proper way to passing that state down from dashboard to the actual vega implementation.

/cc @stacey-gammon

@nyurik
Copy link
Contributor

nyurik commented Mar 21, 2018 •
edited
Loading

An alternative would be to set the Vega vis background to a solid white color (by default, instead of transparent), but that might not look very good.

@aphelionz aphelionz mentioned this issue May 11, 2018
Closed
48 tasks
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@timroes timroes mentioned this issue Nov 7, 2018
Closed
20 tasks
@ThiloSchoenfelder ThiloSchoenfelder mentioned this issue May 14, 2019
Closed
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this May 27, 2019
@PhilippBaranovskiy PhilippBaranovskiy removed their assignment Jun 25, 2019
@VladLasitsa VladLasitsa mentioned this issue Jul 29, 2020
Merged
7 tasks
elasticmachine added a commit to VladLasitsa/kibana that referenced this issue Jul 30, 2020
@elasticmachine
Merge branch 'master' into elastic#16456
b7a07af
elasticmachine added a commit to VladLasitsa/kibana that referenced this issue Aug 3, 2020
@elasticmachine
Merge branch 'master' into elastic#16456
660ef62
elasticmachine added a commit to VladLasitsa/kibana that referenced this issue Aug 5, 2020
@elasticmachine
Merge branch 'master' into elastic#16456
eba4a64
VladLasitsa added a commit to VladLasitsa/kibana that referenced this issue Aug 6, 2020
@VladLasitsa
Merge branch 'master' into elastic#16456
d07bb0c
elasticmachine added a commit to VladLasitsa/kibana that referenced this issue Aug 10, 2020
@elasticmachine
Merge branch 'master' into elastic#16456
b4198a0
VladLasitsa added a commit to VladLasitsa/kibana that referenced this issue Aug 12, 2020
@VladLasitsa
Merge remote-tracking branch 'origin/elastic#16456' into elastic#16456
54d3654
VladLasitsa added a commit to VladLasitsa/kibana that referenced this issue Aug 12, 2020
@VladLasitsa
Merge remote-tracking branch 'upstream/master' into elastic#16456
8563299
elasticmachine added a commit to VladLasitsa/kibana that referenced this issue Aug 15, 2020
@elasticmachine
Merge branch 'master' into elastic#16456
5b3ceda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladLasitsa VladLasitsa

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vega Vega visualizations Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vega vis needs to have visible fonts for dark theme dashboard VladLasitsa/kibana
7 participants
@timroes @PhilippBaranovskiy @nyurik @bhavyarm @VladLasitsa @alexwizp @rayafratkina