-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize] Prevent overwriting managed content #172380
Labels
enhancement
New value added to drive a business result
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
drewdaemon
added
enhancement
New value added to drive a business result
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
labels
Dec 1, 2023
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
added
Feature:Lens
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
labels
Dec 4, 2023
5 tasks
drewdaemon
added
the
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
label
Jan 23, 2024
drewdaemon
added a commit
that referenced
this issue
Jan 31, 2024
## Summary Close #172380 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization. This is how the UI should look for the managed visualization. <img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM" src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — going to happen in #175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this issue
Feb 15, 2024
## Summary Close elastic#172380 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization. This is how the UI should look for the managed visualization. <img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM" src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — going to happen in elastic#175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this issue
Mar 4, 2024
## Summary Close elastic#172380 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization. This is how the UI should look for the managed visualization. <img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM" src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — going to happen in elastic#175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Users should be guided to save changes to managed assets as new content.
UI Changes
Managed status communicated in top nav
Save as new is always true
The text was updated successfully, but these errors were encountered: