Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Dashboard] Merge visualization and panel settings #174136

Open
drewdaemon opened this issue Jan 2, 2024 · 7 comments
Open

[Lens][Dashboard] Merge visualization and panel settings #174136

drewdaemon opened this issue Jan 2, 2024 · 7 comments
Assignees
Labels
blocked Feature:Inline Editing impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Jan 2, 2024

Describe the feature:
Lens panels on a dashboard currently have two actions for customizing the appearance of the panel, both of which open a flyout

  • Edit visualization
  • Panel settings

These experiences could be merged so that users have a one-stop-shop for all settings related to panel appearance. There are technical and ownership reasons for the way it is set up now. However, I can't see any user-facing reason to keep them separate.

Merging the two would simplify the context menu require fewer clicks (and mis-clicks) while customizing Lens dashboard panels.

It might make sense to delay this task until more panel types support inline editing.

Screenshots

Screenshot 2024-01-02 at 2 38 21 PM

the actions

Screenshot 2024-01-02 at 2 40 28 PM

panel settings

Screenshot 2024-01-02 at 2 40 18 PM

visualization settings

@drewdaemon drewdaemon added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula
Copy link
Contributor

stratoula commented Jan 3, 2024

Although this is something we would like to do in the future I don't think we should do it now for 3 reasons:

  • Inline editing is still under progress and we haven't finalized yet the features we want to add
  • Inline editing is a Lens only feature so it will be confusing to have this action to some panels while the Lens panels will include it inside the editing experience.
  • Inline editing is about Lens attributes while panel settings is about dashboard settings. They don't make sense outside a dashboard so contextually I would like to think it more.

@timductive timductive added blocked impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 10, 2024
@ThomThomson
Copy link
Contributor

ThomThomson commented Jan 11, 2024

@stratoula, I agree with your assessment. Additionally, we're currently in the middle of the major Embeddable refactor, which would preclude us from working on this any time soon.

Also bumping the impact up to medium because as a user, the separation of these settings doesn't make sense.

@ThomThomson ThomThomson added loe:x-large Extra Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed loe:needs-research This issue requires some research before it can be worked on or estimated impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 11, 2024
@Heenawter
Copy link
Contributor

Heenawter commented Jan 11, 2024

Noting here that, in user testing for the Links panel (which also has an inline/flyout editing experience), we saw quite a bit of confusion around where different settings lived - it made no sense, from a user perspective, why "Panel settings" were different from the Link-panel-specific creation experience. I assume the same kinds of issues will surface with Lens now that inline editing is available...

In an ideal world, the "Panel settings" flyout should be removed for all non-legacy panel types - we're definitely far from that goal, but I can dream 🙈

@stratoula
Copy link
Contributor

stratoula commented Jan 12, 2024

There is an important distinction between the Lens SOs and the links panel. Lens charts have an editor where they are created, they are not dashboard elements. They have their own names and descriptions. The panel settings overwrite them (which is already very confusing).

So expect from the tech work that needs to be done and the fact that we need a feature parity in dashboard before we do that, we also need to fix the confusion between visualizations names/descriptions and panel names/descriptions. If we don't find a solution for that, moving the panel settings inside the visualization editing will be a big confusion, creating more problems than solving.

@MichaelMarcialis
Copy link
Contributor

The latest design mockups for this issue have been crafted and are ready for handoff to engineering. Some key screenshots from the mockups can be found below. Please view the full Figma document for all mockups and developer notes.


Image

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Inline Editing impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

9 participants