Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inline editing] Pause before editor is shown #188575

Open
ThomThomson opened this issue Jul 17, 2024 · 2 comments
Open

[Inline editing] Pause before editor is shown #188575

ThomThomson opened this issue Jul 17, 2024 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Jul 17, 2024 •
edited
Loading

Issue
There is a noticeable pause after clicking on any Dashboard panel type with inline editing in the add panel menu where the Dashboard appears to be doing nothing.

To reproduce

  1. Empty cache and hard reload the Dashboard
  2. Once the Dashboard is loaded, throttle your network
  3. Press the add panel menu
  4. Choose any panel type with an inline editor, especially ESQL, Links and Image embeddables.
  5. See the flyout close and nothing happens on the Dashboard until the editor is ready.
    Wait

Expected behaviour
Inline editors should show their flyout immediately, with a loading indicator while the contents of the flyout are loading.
@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Dashboard Usability Related to the Dashboard Usability initiative labels Jul 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 assigned rshen91 and unassigned rshen91 Aug 8, 2024
@cqliu1
Copy link
Contributor

cqliu1 commented Aug 8, 2024

We should tackle this at the same time as #174136 and handle this on the flyout wrapper level for all embeddables that use flyouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cqliu1 @ThomThomson @elasticmachine @rshen91