Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] audit errors and warnings #174280

Open
drewdaemon opened this issue Jan 4, 2024 · 2 comments
Open

[Lens] audit errors and warnings #174280

drewdaemon opened this issue Jan 4, 2024 · 2 comments
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@drewdaemon
Copy link
Contributor

Describe the feature:
#147485 provided a new set of patterns for showing errors and warnings in Lens. All existing errors and warnings should be audited WRT these new patterns.

Example questions to ask

  • Is this classified correctly (should an error be a warning instead)?
  • Is this message showing up in the right place (e.g. should it be associated with a particular dimension)?
  • Is there a way to keep users away from this state in the first place?
  • Does it really make sense to block the render in this state?
  • Is this correctly using the UserMessages system (technical question)?
@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@drewdaemon
Copy link
Contributor Author

Another error to take a look at: #93998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants