Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/containers - useGetCases shows a toast error message when an error occurs in the response #178163

Closed
kibanamachine opened this issue Mar 6, 2024 · 5 comments · Fixed by #181254
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/containers - useGetCases shows a toast error message when an error occurs in the response #178163

kibanamachine opened this issue Mar 6, 2024 · 5 comments · Fixed by #181254
Assignees
@cnasikas
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 6, 2024 •
edited
Loading

A test failed on a tracked branch

Error: Timed out in waitForNextUpdate after 1000ms.
    at waitForNextUpdate (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b2f76df98c4bd617/elastic/kibana-on-merge/kibana/node_modules/@testing-library/react-hooks/lib/core/asyncUtils.js:96:13)
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b2f76df98c4bd617/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/containers/use_get_cases.test.tsx:59:5)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Mar 6, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 6, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Mar 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 6, 2024
@cnasikas cnasikas added the Feature:Cases Cases feature label Mar 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Apr 2, 2024
@mistic
skip flaky suite (#178163)
84532ff
@mistic
Copy link
Member

mistic commented Apr 2, 2024

Skipped.

main: 84532ff

@cnasikas cnasikas mentioned this issue Apr 21, 2024
Merged
2 tasks
@cnasikas cnasikas self-assigned this Apr 21, 2024
cnasikas added a commit that referenced this issue Apr 22, 2024
@cnasikas @kibanamachine
[Cases] Fix useGetCases flaky test (#181254)
d5c1335 
## Summary

Following @JiaweiWu advice I replaced `waitForNextUpdate` with
`waitFor`.

Fix: #178163

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 22, 2024
@cnasikas
[Cases] Fix useGetCases flaky test (elastic#181254)
983aed9 
## Summary

Following @JiaweiWu advice I replaced `waitForNextUpdate` with
`waitFor`.

Fix: elastic#178163

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d5c1335)
kibanamachine referenced this issue Apr 22, 2024
@kibanamachine @cnasikas
[8.14] [Cases] Fix useGetCases flaky test (#181254) (#181275)
bce0d98 
# Backport

This will backport the following commits from `main` to `8.14`:
- [[Cases] Fix &#x60;useGetCases&#x60; flaky test
(#181254)](#181254)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christos
Nasikas","email":"christos.nasikas@elastic.co"},"sourceCommit":{"committedDate":"2024-04-22T09:21:00Z","message":"[Cases]
Fix `useGetCases` flaky test (#181254)\n\n## Summary\r\n\r\nFollowing
@JiaweiWu advice I replaced `waitForNextUpdate`
with\r\n`waitFor`.\r\n\r\nFix:
https://github.com/elastic/kibana/issues/178163\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d5c1335f78a0b578092d5e435308f028d4a7feed","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.14.0","v8.15.0"],"title":"[Cases]
Fix `useGetCases` flaky
test","number":181254,"url":"https://github.com/elastic/kibana/pull/181254","mergeCommit":{"message":"[Cases]
Fix `useGetCases` flaky test (#181254)\n\n## Summary\r\n\r\nFollowing
@JiaweiWu advice I replaced `waitForNextUpdate`
with\r\n`waitFor`.\r\n\r\nFix:
https://github.com/elastic/kibana/issues/178163\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d5c1335f78a0b578092d5e435308f028d4a7feed"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181254","number":181254,"mergeCommit":{"message":"[Cases]
Fix `useGetCases` flaky test (#181254)\n\n## Summary\r\n\r\nFollowing
@JiaweiWu advice I replaced `waitForNextUpdate`
with\r\n`waitFor`.\r\n\r\nFix:
https://github.com/elastic/kibana/issues/178163\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d5c1335f78a0b578092d5e435308f028d4a7feed"}}]}]
BACKPORT-->

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Fix useGetCases flaky test cnasikas/kibana
4 participants
@mistic @cnasikas @elasticmachine @kibanamachine