Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Saved Search] Field statistics saved search embeddable broken in Dashboard view mode #180828

Closed
Heenawter opened this issue Apr 15, 2024 · 7 comments · Fixed by #180880
Closed

[Saved Search] Field statistics saved search embeddable broken in Dashboard view mode #180828

Heenawter opened this issue Apr 15, 2024 · 7 comments · Fixed by #180880
Assignees
@qn895
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.14.0

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Apr 15, 2024 •
edited
Loading

Describe the bug:
Field statistics saved search embeddables render a bright red square when a Dashboard is in view mode.

Steps to reproduce:

  1. Create a field statistics saved search in the Discover plugin
  2. Add that embeddable to a dashboard
  3. Switch that dashboard to view mode
  4. 🔥🔥🔥 Embeddable renders as bright red div 🔥🔥🔥

Expected behavior:
The embeddable should render the same in view mode and edit mode

Screenshots (if relevant):

Screen.Recording.2024-04-15.at.9.03.23.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. project:embeddableRebuild labels Apr 15, 2024
@Heenawter Heenawter self-assigned this Apr 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@Heenawter Heenawter mentioned this issue Apr 15, 2024
Merged
4 tasks
@jughosta
Copy link
Contributor

Hi @Heenawter,

Would it be possible to fix it without refactoring embeddables since FF is already tomorrow?

@Heenawter
Copy link
Contributor Author

@jughosta If ya'll have time to fix it before FF, that would be fine!! :)

@Heenawter Heenawter removed their assignment Apr 15, 2024
@jughosta
Copy link
Contributor

What is causing it?

@Heenawter
Copy link
Contributor Author

Heenawter commented Apr 15, 2024 •
edited
Loading

@jughosta I haven't looked into that - it is just something I discovered in my refactor work, but I haven't gotten further than that unfortunately since I assumed I would just fix it as part of the refactor. There are no error messages or anything thrown.

@jughosta
Copy link
Contributor

jughosta commented Apr 15, 2024 •
edited
Loading

Looks like the red overlay is from Eui Sass mixin via mask-image but the same styles work fine on 8.13 branch.

Screenshot 2024-04-15 at 18 17 14

@Heenawter Heenawter removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Apr 15, 2024
@jughosta jughosta mentioned this issue Apr 16, 2024
Merged
jughosta added a commit that referenced this issue Apr 16, 2024
@jughosta
[Discover] Prevent red overlays on Dashboard (#180880)
7c4c707 
- Closes #180828

## Summary

`mask-image` was not working correctly in Google Chrome after [changes
to
border-radius](https://github.com/elastic/kibana/pull/178544/files#diff-d4f343c3886df5fe9a99f56aeaf035c5e7d8723062fc689f6b889398b3c41d6eR22)
of dashboard panels.
This PR applies a quick fix before FF to prevent red overlays.

`kbnDocTableWrapper` is used only for Field Statistics embeddable and
Saved search embeddable with legacy table.

Before:
<img width="500" alt="Screenshot 2024-04-16 at 10 59 42"
src="https://github.com/elastic/kibana/assets/1415710/edd9c5a4-8b66-4d0e-9d6e-34faedd53dfd">

After:
<img width="500" alt="Screenshot 2024-04-16 at 10 59 14"
src="https://github.com/elastic/kibana/assets/1415710/5dcfba69-b41f-4e06-abe0-7736a08650e4">
@qn895 qn895 self-assigned this Apr 23, 2024
@cee-chen cee-chen mentioned this issue Jun 25, 2024
Merged
6 tasks
@davismcphee davismcphee mentioned this issue Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qn895 qn895

Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Prevent red overlays on Dashboard jughosta/kibana
4 participants
@jughosta @Heenawter @elasticmachine @qn895