Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time picker shows [object Object] in absolute tab #182099

Closed
sakurai-youhei opened this issue Apr 30, 2024 · 1 comment · Fixed by #182152
Closed

Time picker shows [object Object] in absolute tab #182099

sakurai-youhei opened this issue Apr 30, 2024 · 1 comment · Fixed by #182152
Labels
bug Fixes for quality problems that affect the customer experience Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@sakurai-youhei
Copy link
Member

sakurai-youhei commented Apr 30, 2024 •
edited
Loading

Kibana version: 8.15.0 (main branch)

Elasticsearch version: 8.15.0-SNAPSHOT

Server OS version: Ubuntu 22.04.3 LTS

Browser version: Chrome Version 124.0.6367.92 (Official Build) (64-bit)

Browser OS version: Windows 11 10.0.22621 N/A Build 22621

Original install method (e.g. download page, yum, from source, etc.): yarn start

Describe the bug:
kibana-bug-en
[object Object] is shown at the bottom of the absolute tab in the time picker.

Steps to reproduce:

  1. Click the time picker.
  2. Go to the absolute tab.
  3. Insert a white space to the date form.

Expected behavior:
kibana-bug-fixed-en
The date format should be shown.

Any additional context:

The EuiSuperDatePicker passes not a string but an object to dateFormat now.

I will open a PR to fix this issue shortly.
@sakurai-youhei sakurai-youhei added the bug Fixes for quality problems that affect the customer experience label Apr 30, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 30, 2024
@sakurai-youhei sakurai-youhei changed the title Time picker shows [object: Object] in absolute tab Time picker shows [object Object] in absolute tab Apr 30, 2024
@sakurai-youhei sakurai-youhei mentioned this issue Apr 30, 2024
Merged
4 tasks
@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks labels May 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 2, 2024
sakurai-youhei added a commit that referenced this issue May 9, 2024
@sakurai-youhei @kibanamachine
Fix time picker not to show [object Object] (#182152)
50d6748 
## Summary

This PR fixes one i18n mapping for EUI to render the `dateFormat` = `MMM
D, YYYY @ HH:mm:ss.SSS` correctly at the bottom.

Note: It showed `[object Object]` instead of `MMM D, YYYY @
HH:mm:ss.SSS` before this fix.

Fixes #182099

## Release note

Fixes time picker to show allowed formats properly in absolute tabs.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 9, 2024
@sakurai-youhei
Fix time picker not to show [object Object] (elastic#182152)
6a9eeca 
## Summary

This PR fixes one i18n mapping for EUI to render the `dateFormat` = `MMM
D, YYYY @ HH:mm:ss.SSS` correctly at the bottom.

Note: It showed `[object Object]` instead of `MMM D, YYYY @
HH:mm:ss.SSS` before this fix.

Fixes elastic#182099

## Release note

Fixes time picker to show allowed formats properly in absolute tabs.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 50d6748)
kibanamachine referenced this issue May 9, 2024
@kibanamachine @sakurai-youhei
[8.14] Fix time picker not to show &#x60;[object Object]&#x60; (#182152…
23ed120 
…) (#183022)

# Backport

This will backport the following commits from `main` to `8.14`:
- [Fix time picker not to show &#x60;[object Object]&#x60;
(#182152)](#182152)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Youhei
Sakurai","email":"youhei.sakurai@elastic.co"},"sourceCommit":{"committedDate":"2024-05-09T10:08:07Z","message":"Fix
time picker not to show `[object Object]` (#182152)\n\n##
Summary\r\n\r\nThis PR fixes one i18n mapping for EUI to render the
`dateFormat` = `MMM\r\nD, YYYY @ HH:mm:ss.SSS` correctly at the
bottom.\r\n\r\nNote: It showed `[object Object]` instead of `MMM D, YYYY
@\r\nHH:mm:ss.SSS` before this fix.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/182099\r\n\r\n## Release
note\r\n\r\nFixes time picker to show allowed formats properly in
absolute tabs.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"50d674867bdf1af37f6b61a89151e52c5da2bdbd","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","v8.15.0"],"title":"Fix
time picker not to show `[object
Object]`","number":182152,"url":"https://github.com/elastic/kibana/pull/182152","mergeCommit":{"message":"Fix
time picker not to show `[object Object]` (#182152)\n\n##
Summary\r\n\r\nThis PR fixes one i18n mapping for EUI to render the
`dateFormat` = `MMM\r\nD, YYYY @ HH:mm:ss.SSS` correctly at the
bottom.\r\n\r\nNote: It showed `[object Object]` instead of `MMM D, YYYY
@\r\nHH:mm:ss.SSS` before this fix.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/182099\r\n\r\n## Release
note\r\n\r\nFixes time picker to show allowed formats properly in
absolute tabs.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"50d674867bdf1af37f6b61a89151e52c5da2bdbd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182152","number":182152,"mergeCommit":{"message":"Fix
time picker not to show `[object Object]` (#182152)\n\n##
Summary\r\n\r\nThis PR fixes one i18n mapping for EUI to render the
`dateFormat` = `MMM\r\nD, YYYY @ HH:mm:ss.SSS` correctly at the
bottom.\r\n\r\nNote: It showed `[object Object]` instead of `MMM D, YYYY
@\r\nHH:mm:ss.SSS` before this fix.\r\n\r\nFixes
https://github.com/elastic/kibana/issues/182099\r\n\r\n## Release
note\r\n\r\nFixes time picker to show allowed formats properly in
absolute tabs.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"50d674867bdf1af37f6b61a89151e52c5da2bdbd"}}]}]
BACKPORT-->

Co-authored-by: Youhei Sakurai <youhei.sakurai@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix time picker not to show [object Object] sakurai-youhei/kibana
3 participants
@sakurai-youhei @dej611 @elasticmachine