Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Remove unnecessary encoding/decoding of the ES-response in Kibana server #189640

Closed
thomasneirynck opened this issue Jul 31, 2024 · 5 comments · Fixed by #193060
Closed

[Search] Remove unnecessary encoding/decoding of the ES-response in Kibana server #189640

thomasneirynck opened this issue Jul 31, 2024 · 5 comments · Fixed by #193060
Assignees
@lukasolson @ppisljar
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 31, 2024 •
edited by kertal
Loading

Describe the feature:

Remove decoding and re-encoding of the ES-response from Kibana-server. The elasticsearch-js client now does this by default. Using the asStream option will avoid this.

Describe a specific use case for the feature:

This is a performance improvement (see outcomes listed here #184713)

For async-search, this is blocked by elastic/elasticsearch#109576.

Tasks
Preview Give feedback
No tasks being tracked yet.
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 31, 2024
@dmlemeshko dmlemeshko added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 19, 2024
@petrklapka
Copy link
Member

@dmlemeshko - Looked at this during our Triage today, doesn't seem related to our catalog. Shouldn't this be the disco and viz teams? Or am I missing something bud?

@thomasneirynck
Copy link
Contributor Author

@petrklapka This is for now in the AnalystXp team. I created this as a compagnon ER for #186139, to track items a little bit more fine grained.

cc @lukasolson

@thomasneirynck thomasneirynck added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Aug 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@thomasneirynck thomasneirynck removed the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 19, 2024
@kertal kertal added blocked impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Aug 22, 2024
@lukasolson
Copy link
Member

#191003 is a PoC of this specifically for ES|QL.

@ppisljar ppisljar mentioned this issue Sep 17, 2024
Merged
@kertal kertal removed the blocked label Sep 26, 2024
mbondyra pushed a commit to mbondyra/kibana that referenced this issue Nov 8, 2024
@ppisljar @mbondyra
pass elasticsearch response to browser as a stream (elastic#193060)
743cbc1 
Remove decoding and re-encoding of the ES-response from Kibana-server.
Resolves elastic#189640
lukasolson pushed a commit to lukasolson/kibana that referenced this issue Jan 7, 2025
@ppisljar
pass elasticsearch response to browser as a stream (elastic#193060)
86ee030 
Remove decoding and re-encoding of the ES-response from Kibana-server.
Resolves elastic#189640

(cherry picked from commit 7b81bcf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

@ppisljar ppisljar

Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pass elasticsearch response to browser as a stream ppisljar/kibana
7 participants
@kertal @lukasolson @thomasneirynck @dmlemeshko @ppisljar @elasticmachine @petrklapka