Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Managed Content] Maps and saved search refer to the same saved object after duplicating managed dashboard #190138

Open
mbondyra opened this issue Aug 8, 2024 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Aug 8, 2024

Kibana version:
main

  1. Create a managed dashboard (you can use an object from [Dashboard] Keep managed panels out of unmanaged dashboards #176006)
  2. Duplicate it
  3. Behavior: Maps and saved search are referencing the same object as from managed dashboard – now user can edit the objects they should not
Screenshot 2024-08-08 at 15 26 47

It's a regression coming from the fact that our managed content tests were skipped for a few months now: tested here

Here's the code that caused a regression:
Maps: https://github.com/elastic/kibana/pull/178158/files#diff-550e794ceab85d42296fe9a224b06e66d41f036863b636565ab6d76f73d85572L227
Saved search: 5c4eae1#diff-3baaeaeef5893a5a4db6379a1ed888406a8584cb9d0c7440f273040e4aa28166L121

We have to fix it asap, otherwise we'll have to also fix it for other embeddables as the refactoring happens.

This should be included in this PR: #180938, but somehow it doesn't work correctly (https://github.com/elastic/kibana/pull/180938/files#diff-f97c836c673c4de4b70b86ed593cca242d90956d9850ee96b124f6d46587ec32L285)

@elastic/kibana-presentation I've assigned it to you as it's related to embeddable 🙏🏼

@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra changed the title [Managed Content] Maps and saved search refer to the same saved object after duplicating managed dashboard [Dashboard][Managed Content] Maps and saved search refer to the same saved object after duplicating managed dashboard Aug 8, 2024
@mbondyra mbondyra added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants