Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Interactive Managed Dashboard Popover vs badge #189404

Merged
merged 69 commits into from
Aug 21, 2024

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Jul 29, 2024

Summary

Closes ##179152

This PR makes the managed badge into an interactive popover that allows users to duplicate the managed dashboard. The user is automatically redirected to the new dashboard where they can edit it and make changes.

Checklist

@rshen91 rshen91 self-assigned this Jul 29, 2024
@rshen91 rshen91 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Dashboard Dashboard related features release_note:enhancement backport:skip This commit does not require backporting v8.16.0 labels Jul 29, 2024
@rshen91 rshen91 changed the title [Dashboard] Managed popover vs badge [Dashboard] Interactive Managed popover vs badge Jul 29, 2024
@rshen91 rshen91 changed the title [Dashboard] Interactive Managed popover vs badge [Dashboard] Interactive Managed Dashboard Popover vs badge Jul 29, 2024
@rshen91
Copy link
Contributor Author

rshen91 commented Jul 29, 2024

/ci

@rshen91
Copy link
Contributor Author

rshen91 commented Jul 30, 2024

/ci

@rshen91 rshen91 requested a review from andreadelrio July 30, 2024 15:57
@rshen91
Copy link
Contributor Author

rshen91 commented Jul 31, 2024

/ci

@rshen91 rshen91 marked this pull request as ready for review July 31, 2024 21:23
@rshen91 rshen91 requested a review from a team as a code owner July 31, 2024 21:23
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry - in my testing, I noticed that we are creating the clone but not redirecting on modal save:

Screen.Recording.2024-08-14.at.1.19.40.PM.mov

Do you mind looking into that? Taking a look at how the normal "Duplicate" button in the top nav works should help you out here 🙇 If you need help, feel free to reach out!!

@rshen91 rshen91 requested a review from Heenawter August 15, 2024 14:15
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy LGTM!

@rshen91 rshen91 requested a review from Heenawter August 20, 2024 16:15
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits about the strings file, but those are all pretty minor. Everything else LGTM, thanks so much for your work on this 🎉 🎉 Code review + tested locally.

The cloned dashboard is loading with unsaved changes, but this is also happening with the normal duplicate functionality so I think this may have to do with some of the other managed Dashboard issues (such as #190138).

@rshen91 rshen91 enabled auto-merge (squash) August 21, 2024 13:30
auto-merge was automatically disabled August 21, 2024 14:14

Pull Request is not mergeable

@rshen91 rshen91 enabled auto-merge (squash) August 21, 2024 15:17
@rshen91 rshen91 removed request for a team and ThomThomson August 21, 2024 15:17
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #77 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Prebuilt Rules status get_prebuilt_rules_status should return empty structure when no prebuilt rule assets

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/managed-content-badge 2 3 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 541.0KB 542.2KB +1.2KB
discover 843.6KB 843.6KB +22.0B
lens 1.5MB 1.5MB +21.0B
maps 3.0MB 3.0MB +22.0B
visualizations 299.5KB 299.5KB +18.0B
total +1.3KB
Unknown metric groups

API count

id before after diff
@kbn/managed-content-badge 2 3 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 merged commit 5bd3f90 into elastic:main Aug 21, 2024
20 checks passed
@rshen91 rshen91 deleted the managed-popover branch August 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants