-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Interactive Managed Dashboard Popover vs badge #189404
Conversation
/ci |
/ci |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So sorry - in my testing, I noticed that we are creating the clone but not redirecting on modal save:
Screen.Recording.2024-08-14.at.1.19.40.PM.mov
Do you mind looking into that? Taking a look at how the normal "Duplicate" button in the top nav works should help you out here 🙇 If you need help, feel free to reach out!!
src/plugins/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
Outdated
Show resolved
Hide resolved
…ard_top_nav.tsx Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
src/plugins/dashboard/public/dashboard_container/embeddable/api/run_save_functions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy LGTM!
src/plugins/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits about the strings file, but those are all pretty minor. Everything else LGTM, thanks so much for your work on this 🎉 🎉 Code review + tested locally.
The cloned dashboard is loading with unsaved changes, but this is also happening with the normal duplicate functionality so I think this may have to do with some of the other managed Dashboard issues (such as #190138).
src/plugins/dashboard/public/dashboard_app/_dashboard_app_strings.ts
Outdated
Show resolved
Hide resolved
src/plugins/dashboard/public/dashboard_app/_dashboard_app_strings.ts
Outdated
Show resolved
Hide resolved
src/plugins/dashboard/public/dashboard_app/_dashboard_app_strings.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @rshen91 |
Summary
Closes ##179152
This PR makes the managed badge into an interactive popover that allows users to duplicate the managed dashboard. The user is automatically redirected to the new dashboard where they can edit it and make changes.
Checklist