Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Management] Some field format changes do not persist #19037

Closed
chrisronline opened this issue May 14, 2018 · 2 comments
Closed

[Management] Some field format changes do not persist #19037

chrisronline opened this issue May 14, 2018 · 2 comments

Comments

@chrisronline
Copy link
Contributor

The main one I noticed is changing from a Boolean to anything else doesn't seem to work at all.

Steps to reproduce:

  1. Create an index pattern with at least a single field
  2. Change the field format for that field to a Boolean (In my example, it is a string in ES)
  3. Try and reset the formatting for that field OR change the format from Boolean to Truncated String
@chrisronline
Copy link
Contributor Author

Also, I can't seem to reset any field format to default

@chrisronline chrisronline mentioned this issue May 14, 2018
Merged
chrisronline added a commit to chrisronline/kibana that referenced this issue May 15, 2018
@chrisronline
Fix a couple issues with saving field formats, elastic#19037
af6fdda
chrisronline added a commit that referenced this issue May 22, 2018
@chrisronline
[Management] Enable index pattern version conflicts (#18937)
54b7a68 
* Pass the version along so we can get version conflict errors, then try and resolve if we can

* Update the version post save

* Refactor slightly to match setId pattern

* Tests and updates to ensure the actual changes aren't clobbered

* Ensure we return the id

* Avoid infinite recursion, welcome suggestions on how to unit test this

* Change logic for refresh fields UI button. Now it will re-call init and force a fields refresh. This ensures we pick up on field format (and other) changes

* Fix a couple issues with saving field formats, #19037

* Use the right key for version
chrisronline added a commit to chrisronline/kibana that referenced this issue May 22, 2018
@chrisronline
[Management] Enable index pattern version conflicts (elastic#18937)
ae5835f 
* Pass the version along so we can get version conflict errors, then try and resolve if we can

* Update the version post save

* Refactor slightly to match setId pattern

* Tests and updates to ensure the actual changes aren't clobbered

* Ensure we return the id

* Avoid infinite recursion, welcome suggestions on how to unit test this

* Change logic for refresh fields UI button. Now it will re-call init and force a fields refresh. This ensures we pick up on field format (and other) changes

* Fix a couple issues with saving field formats, elastic#19037

* Use the right key for version
chrisronline added a commit that referenced this issue May 22, 2018
@chrisronline
[Management] Enable index pattern version conflicts (#18937) (#19300)
55b8130 
* Pass the version along so we can get version conflict errors, then try and resolve if we can

* Update the version post save

* Refactor slightly to match setId pattern

* Tests and updates to ensure the actual changes aren't clobbered

* Ensure we return the id

* Avoid infinite recursion, welcome suggestions on how to unit test this

* Change logic for refresh fields UI button. Now it will re-call init and force a fields refresh. This ensures we pick up on field format (and other) changes

* Fix a couple issues with saving field formats, #19037

* Use the right key for version
@chrisronline
Copy link
Contributor Author

Closed by #18937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisronline