Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Observability AI Assistant API Integration tests (enterprise).x-pack/test/observability_ai_assistant_functional/tests/feature_controls/settings_security·spec·ts - Observability AI Assistant Functional tests feature_controls/settings_security.spec.ts ai assistant management privileges all privileges displays failure toast on failed request #190637

Closed
kibanamachine opened this issue Aug 15, 2024 · 3 comments · Fixed by #191531
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Obs AI Assistant Observability AI Assistant

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 15, 2024

A test failed on a tracked branch

Error: retry.try reached timeout 120000 ms
TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="observabilityAiAssistantManagementBottomBarActionsButton"])
Wait timed out after 10015ms
    at /opt/buildkite-agent/builds/bk-agent-prod-gcp-1723745541238297467/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:913:22
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:84:7)
    at RetryService.try (retry.ts:51:12)
    at Proxy.clickByCssSelector (find.ts:419:5)
    at TestSubjects.click (test_subjects.ts:168:5)
    at settings_security.spec.ts:100:13

First failure: kibana-on-merge - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 15, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 15, 2024
@dmlemeshko dmlemeshko added the Team:Obs AI Assistant Observability AI Assistant label Aug 19, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 19, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@mistic
Copy link
Member

mistic commented Aug 26, 2024

Skipped.

main: 9ea2adb

neptunian added a commit that referenced this issue Aug 28, 2024
This test can be flaky because the "save" button only appears if the
there is change in one of the form values, but the change can be "reset"
if the state takes a while to load in some edge case so the "save"
button does not appear. Given I already added a test for making sure
that the inputs are disabled when a user does not have access to
Advanced Settings, this test is somewhat redundant in terms of security
access and given its flaky nature, I would like to remove it. I could
see having it in another test suite that tests general functionality of
the settings page and a unit test for
[`useEditableSettings`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_shared/public/hooks/use_editable_settings.tsx#L49).

Closes #190637

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants