-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[canvas][maps] by-value map embeddables have broken layers #190994
Labels
bug
Fixes for quality problems that affect the customer experience
project:embeddableRebuild
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.15.0
Comments
nreese
added
the
bug
Fixes for quality problems that affect the customer experience
label
Aug 21, 2024
nreese
added
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
project:embeddableRebuild
v8.15.0
labels
Aug 21, 2024
Pinging @elastic/kibana-presentation (Team:Presentation) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Aug 21, 2024
) Resolves elastic#190994 ### Test instructions 1. create new canvas workpad 2. Click "Select type" and select "Maps" 3. Add a documents layer to your map and click "Save and return" 4. Click "canvas" bread crumb to go back to canvas listing page 5. Open you work pad again. Map should still display data (cherry picked from commit 1da0967)
kibanamachine
added a commit
that referenced
this issue
Aug 21, 2024
) (#191011) # Backport This will backport the following commits from `main` to `8.15`: - [[canvas] fix by-value map embeddables have broken layers (#190996)](#190996) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-08-21T17:19:35Z","message":"[canvas] fix by-value map embeddables have broken layers (#190996)\n\nResolves #190994 Test instructions\r\n1. create new canvas workpad\r\n2. Click \"Select type\" and select \"Maps\"\r\n3. Add a documents layer to your map and click \"Save and return\"\r\n4. Click \"canvas\" bread crumb to go back to canvas listing page\r\n5. Open you work pad again. Map should still display data","sha":"1da096793d775d9dacafc6a744b84caf5cb2a5eb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","project:embeddableRebuild","v8.16.0","v8.15.1"],"title":"[canvas] fix by-value map embeddables have broken layers","number":190996,"url":"#190996 fix by-value map embeddables have broken layers (#190996)\n\nResolves #190994 Test instructions\r\n1. create new canvas workpad\r\n2. Click \"Select type\" and select \"Maps\"\r\n3. Add a documents layer to your map and click \"Save and return\"\r\n4. Click \"canvas\" bread crumb to go back to canvas listing page\r\n5. Open you work pad again. Map should still display data","sha":"1da096793d775d9dacafc6a744b84caf5cb2a5eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"#190996 fix by-value map embeddables have broken layers (#190996)\n\nResolves #190994 Test instructions\r\n1. create new canvas workpad\r\n2. Click \"Select type\" and select \"Maps\"\r\n3. Add a documents layer to your map and click \"Save and return\"\r\n4. Click \"canvas\" bread crumb to go back to canvas listing page\r\n5. Open you work pad again. Map should still display data","sha":"1da096793d775d9dacafc6a744b84caf5cb2a5eb"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
project:embeddableRebuild
regression
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.15.0
Background
Canvas is missing support for by-value reference injection and extraction. Original issue #101639 closed by #123515. The closing PR only added migration support, not reference injection and extraction.
steps
The text was updated successfully, but these errors were encountered: