Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control disappears after saving, modifying, and reseting changes #191155

Closed
nreese opened this issue Aug 23, 2024 · 2 comments
Closed

control disappears after saving, modifying, and reseting changes #191155

nreese opened this issue Aug 23, 2024 · 2 comments
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Aug 23, 2024

Steps

  1. start kibana with yarn start --run-examples
  2. go to controls developer example
  3. click reset to start from fresh example
  4. add new range control on bytes_counter field.
  5. Click save
  6. select range for bytes_counter control
  7. Click reset, notice how the control disappears.
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas project:embeddableRebuild labels Aug 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

This was referenced Aug 23, 2024
Closed
Merged
nreese added a commit that referenced this issue Aug 30, 2024
@nreese @elasticmachine
@kibanamachine @Heenawter
Integrate react control group embeddable into dashboard container (#1…
c272d97 
…90273)

closes #191137,
#190988,
#191155

PR replaces legacy embeddable control group implementation with react
control group implementation in DashboardContainer.

### Test instructions
1. Open dashboard via dashboard application or portable dashboard
2. Mess around with controls. There should be no changes in behavior

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
@nreese
Copy link
Contributor Author

nreese commented Aug 30, 2024

Closed by #190273

@nreese nreese closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix control group unsaved changes issues nreese/kibana
2 participants
@nreese @elasticmachine