[Dataset quality] Remove DataStreams stats API usage on serverless #192166
Assignees
Labels
Team:obs-ux-logs
Observability Logs User Experience Team
Comments
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
yngrdyn
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 19, 2024
…lastic#192839) Closes elastic#192166. This PR aims to remove the usage of `DataStreamStats` API in serverless. Aditionally we now make use of the new verbose mode for `DataStream` API which allow us to still show the `lastActivity` for serverless projects. The change was implemented for both flavours. Visually it won't represent any changes at the moment, but here are the two flavours still working as before https://github.com/user-attachments/assets/18cc9b14-24f1-438a-ac07-565c3e728991 (cherry picked from commit 444f95e)
kibanamachine
referenced
this issue
Sep 20, 2024
…less (#192839) (#193468) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] remove usage of dataStreamStats API in serverless (#192839)](#192839) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"yngrid.coello@elastic.co"},"sourceCommit":{"committedDate":"2024-09-19T18:47:45Z","message":"[Dataset quality] remove usage of dataStreamStats API in serverless (#192839)\n\nCloses https://github.com/elastic/kibana/issues/192166.\n\nThis PR aims to remove the usage of `DataStreamStats` API in serverless.\nAditionally we now make use of the new verbose mode for `DataStream` API\nwhich allow us to still show the `lastActivity` for serverless projects.\nThe change was implemented for both flavours.\n\nVisually it won't represent any changes at the moment, but here are the\ntwo flavours still working as before\n\n\nhttps://github.com/user-attachments/assets/18cc9b14-24f1-438a-ac07-565c3e728991","sha":"444f95ed0b4a2d251851f40d62b126544a6c17c0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"[Dataset quality] remove usage of dataStreamStats API in serverless","number":192839,"url":"https://github.com/elastic/kibana/pull/192839","mergeCommit":{"message":"[Dataset quality] remove usage of dataStreamStats API in serverless (#192839)\n\nCloses https://github.com/elastic/kibana/issues/192166.\n\nThis PR aims to remove the usage of `DataStreamStats` API in serverless.\nAditionally we now make use of the new verbose mode for `DataStream` API\nwhich allow us to still show the `lastActivity` for serverless projects.\nThe change was implemented for both flavours.\n\nVisually it won't represent any changes at the moment, but here are the\ntwo flavours still working as before\n\n\nhttps://github.com/user-attachments/assets/18cc9b14-24f1-438a-ac07-565c3e728991","sha":"444f95ed0b4a2d251851f40d62b126544a6c17c0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192839","number":192839,"mergeCommit":{"message":"[Dataset quality] remove usage of dataStreamStats API in serverless (#192839)\n\nCloses https://github.com/elastic/kibana/issues/192166.\n\nThis PR aims to remove the usage of `DataStreamStats` API in serverless.\nAditionally we now make use of the new verbose mode for `DataStream` API\nwhich allow us to still show the `lastActivity` for serverless projects.\nThe change was implemented for both flavours.\n\nVisually it won't represent any changes at the moment, but here are the\ntwo flavours still working as before\n\n\nhttps://github.com/user-attachments/assets/18cc9b14-24f1-438a-ac07-565c3e728991","sha":"444f95ed0b4a2d251851f40d62b126544a6c17c0"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the introduction of DataStreams API verbose mode and dataStreamStats API being marked as internal we need to remove the usages of the latter.
Right now we make use of this API to retrieve
maximum_timestampwhich is now included in the verbose mode of dataStreams API.💡 Implementation hints
maximum_timestampfor both flavours so we keep the code as agnostic-deployment as we can, and leave the stats to only query sizes in stateful (which is unavoidable different in serverless)The text was updated successfully, but these errors were encountered: