Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[map embeddable] filter notification badge disappears when canceling edit #193601

Closed
nreese opened this issue Sep 20, 2024 · 2 comments
Closed

[map embeddable] filter notification badge disappears when canceling edit #193601

nreese opened this issue Sep 20, 2024 · 2 comments
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Sep 20, 2024

Steps to reproduce issue

  1. install sample web logs
  2. create new dashboard
  3. click "Add panel" and select "Maps"
  4. add a filter pill to the map, click "Save and return"
  5. Notice the filter notification badge in the map panel. Click it and click "Edit filters"
  6. Click "cancel"
  7. Notice how filter badge no longer exists for the panel.
@nreese nreese added bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

This was referenced Sep 20, 2024
Closed
Merged
nreese added a commit that referenced this issue Sep 23, 2024
@nreese @elasticmachine
[maps embeddable] fix map layers disappear from map panel when using …
a8ebc7f 
…session storage to continue editing a dashboard (#193629)

Closes #190468 and
#193601

Dashboard unsaved changes for a panel are obtained from the embeddable
comparator subject for each comparator. If comparator subject does not
return a value, then this information is lost when returning to a
dashboard with unsaved changes. This is why layers and filters where
disappearing from a map when returning to a dashboard with unsaved
changes. This PR resolves this issue by providing comparator subjects
and setters for `savedObjectId`, `attributes`, and `mapSettings`.

PR also resolves issue of passing props from `MapRenderer` component
into map embeddable. Instead of passing props via state, props should be
passed from `MapRenderer` parent api.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 23, 2024
@nreese
[maps embeddable] fix map layers disappear from map panel when using …
5ac605b 
…session storage to continue editing a dashboard (elastic#193629)

Closes elastic#190468 and
elastic#193601

Dashboard unsaved changes for a panel are obtained from the embeddable
comparator subject for each comparator. If comparator subject does not
return a value, then this information is lost when returning to a
dashboard with unsaved changes. This is why layers and filters where
disappearing from a map when returning to a dashboard with unsaved
changes. This PR resolves this issue by providing comparator subjects
and setters for `savedObjectId`, `attributes`, and `mapSettings`.

PR also resolves issue of passing props from `MapRenderer` component
into map embeddable. Instead of passing props via state, props should be
passed from `MapRenderer` parent api.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit a8ebc7f)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 23, 2024
@nreese
[maps embeddable] fix map layers disappear from map panel when using …
cb14612 
…session storage to continue editing a dashboard (elastic#193629)

Closes elastic#190468 and
elastic#193601

Dashboard unsaved changes for a panel are obtained from the embeddable
comparator subject for each comparator. If comparator subject does not
return a value, then this information is lost when returning to a
dashboard with unsaved changes. This is why layers and filters where
disappearing from a map when returning to a dashboard with unsaved
changes. This PR resolves this issue by providing comparator subjects
and setters for `savedObjectId`, `attributes`, and `mapSettings`.

PR also resolves issue of passing props from `MapRenderer` component
into map embeddable. Instead of passing props via state, props should be
passed from `MapRenderer` parent api.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit a8ebc7f)
kibanamachine added a commit that referenced this issue Sep 23, 2024
@kibanamachine @nreese
[8.x] [maps embeddable] fix map layers disappear from map panel when …
58480de 
…using session storage to continue editing a dashboard (#193629) (#193797)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[maps embeddable] fix map layers disappear from map panel when using
session storage to continue editing a dashboard
(#193629)](#193629)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T20:58:09Z","message":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a dashboard (#193629)\n\nCloses
#190468
and\r\nhttps://github.com//issues/193601\r\n\r\nDashboard
unsaved changes for a panel are obtained from the
embeddable\r\ncomparator subject for each comparator. If comparator
subject does not\r\nreturn a value, then this information is lost when
returning to a\r\ndashboard with unsaved changes. This is why layers and
filters where\r\ndisappearing from a map when returning to a dashboard
with unsaved\r\nchanges. This PR resolves this issue by providing
comparator subjects\r\nand setters for `savedObjectId`, `attributes`,
and `mapSettings`.\r\n\r\nPR also resolves issue of passing props from
`MapRenderer` component\r\ninto map embeddable. Instead of passing props
via state, props should be\r\npassed from `MapRenderer` parent
api.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"a8ebc7f4686e359e9893e7e6fed291711c38dad4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","Feature:Maps","v8.16.0","backport:version","v8.15.3"],"title":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a
dashboard","number":193629,"url":"https://github.com/elastic/kibana/pull/193629","mergeCommit":{"message":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a dashboard (#193629)\n\nCloses
#190468
and\r\nhttps://github.com//issues/193601\r\n\r\nDashboard
unsaved changes for a panel are obtained from the
embeddable\r\ncomparator subject for each comparator. If comparator
subject does not\r\nreturn a value, then this information is lost when
returning to a\r\ndashboard with unsaved changes. This is why layers and
filters where\r\ndisappearing from a map when returning to a dashboard
with unsaved\r\nchanges. This PR resolves this issue by providing
comparator subjects\r\nand setters for `savedObjectId`, `attributes`,
and `mapSettings`.\r\n\r\nPR also resolves issue of passing props from
`MapRenderer` component\r\ninto map embeddable. Instead of passing props
via state, props should be\r\npassed from `MapRenderer` parent
api.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"a8ebc7f4686e359e9893e7e6fed291711c38dad4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193629","number":193629,"mergeCommit":{"message":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a dashboard (#193629)\n\nCloses
#190468
and\r\nhttps://github.com//issues/193601\r\n\r\nDashboard
unsaved changes for a panel are obtained from the
embeddable\r\ncomparator subject for each comparator. If comparator
subject does not\r\nreturn a value, then this information is lost when
returning to a\r\ndashboard with unsaved changes. This is why layers and
filters where\r\ndisappearing from a map when returning to a dashboard
with unsaved\r\nchanges. This PR resolves this issue by providing
comparator subjects\r\nand setters for `savedObjectId`, `attributes`,
and `mapSettings`.\r\n\r\nPR also resolves issue of passing props from
`MapRenderer` component\r\ninto map embeddable. Instead of passing props
via state, props should be\r\npassed from `MapRenderer` parent
api.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"a8ebc7f4686e359e9893e7e6fed291711c38dad4"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine added a commit that referenced this issue Sep 23, 2024
@kibanamachine @nreese
[8.15] [maps embeddable] fix map layers disappear from map panel when…
0d3645d 
… using session storage to continue editing a dashboard (#193629) (#193796)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[maps embeddable] fix map layers disappear from map panel when using
session storage to continue editing a dashboard
(#193629)](#193629)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T20:58:09Z","message":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a dashboard (#193629)\n\nCloses
#190468
and\r\nhttps://github.com//issues/193601\r\n\r\nDashboard
unsaved changes for a panel are obtained from the
embeddable\r\ncomparator subject for each comparator. If comparator
subject does not\r\nreturn a value, then this information is lost when
returning to a\r\ndashboard with unsaved changes. This is why layers and
filters where\r\ndisappearing from a map when returning to a dashboard
with unsaved\r\nchanges. This PR resolves this issue by providing
comparator subjects\r\nand setters for `savedObjectId`, `attributes`,
and `mapSettings`.\r\n\r\nPR also resolves issue of passing props from
`MapRenderer` component\r\ninto map embeddable. Instead of passing props
via state, props should be\r\npassed from `MapRenderer` parent
api.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"a8ebc7f4686e359e9893e7e6fed291711c38dad4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","Feature:Maps","v8.16.0","backport:version","v8.15.3"],"title":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a
dashboard","number":193629,"url":"https://github.com/elastic/kibana/pull/193629","mergeCommit":{"message":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a dashboard (#193629)\n\nCloses
#190468
and\r\nhttps://github.com//issues/193601\r\n\r\nDashboard
unsaved changes for a panel are obtained from the
embeddable\r\ncomparator subject for each comparator. If comparator
subject does not\r\nreturn a value, then this information is lost when
returning to a\r\ndashboard with unsaved changes. This is why layers and
filters where\r\ndisappearing from a map when returning to a dashboard
with unsaved\r\nchanges. This PR resolves this issue by providing
comparator subjects\r\nand setters for `savedObjectId`, `attributes`,
and `mapSettings`.\r\n\r\nPR also resolves issue of passing props from
`MapRenderer` component\r\ninto map embeddable. Instead of passing props
via state, props should be\r\npassed from `MapRenderer` parent
api.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"a8ebc7f4686e359e9893e7e6fed291711c38dad4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193629","number":193629,"mergeCommit":{"message":"[maps
embeddable] fix map layers disappear from map panel when using session
storage to continue editing a dashboard (#193629)\n\nCloses
#190468
and\r\nhttps://github.com//issues/193601\r\n\r\nDashboard
unsaved changes for a panel are obtained from the
embeddable\r\ncomparator subject for each comparator. If comparator
subject does not\r\nreturn a value, then this information is lost when
returning to a\r\ndashboard with unsaved changes. This is why layers and
filters where\r\ndisappearing from a map when returning to a dashboard
with unsaved\r\nchanges. This PR resolves this issue by providing
comparator subjects\r\nand setters for `savedObjectId`, `attributes`,
and `mapSettings`.\r\n\r\nPR also resolves issue of passing props from
`MapRenderer` component\r\ninto map embeddable. Instead of passing props
via state, props should be\r\npassed from `MapRenderer` parent
api.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"a8ebc7f4686e359e9893e7e6fed291711c38dad4"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
@nreese
Copy link
Contributor Author

nreese commented Sep 25, 2024

Closed by #193629

@nreese nreese closed this as completed Sep 25, 2024
@nreese nreese self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nreese @elasticmachine