Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Can't clear unenrollment timeout from agent policy #194221

Closed
jen-huang opened this issue Sep 26, 2024 · 1 comment · Fixed by #194338
Closed

[Fleet] Can't clear unenrollment timeout from agent policy #194221

jen-huang opened this issue Sep 26, 2024 · 1 comment · Fixed by #194338
Assignees
@jen-huang
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

After #191674, it's not possible to clear unenrollment timeout field once a value has been entered since the validation doesn't pass.

Image

This is an optional field so it should be clearable.
@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 26, 2024
@jen-huang jen-huang self-assigned this Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang mentioned this issue Sep 27, 2024
Merged
jen-huang added a commit that referenced this issue Sep 30, 2024
@jen-huang
Revert "[UII] Fix client-side validation for agent policy timeout fie…
6792cb4 
…lds (#191674)" (#194338)

## Summary

Resolves #194221.

This PR reverts commit f29bf1c. Timeout
fields should be clearable with undefined value or zero.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 30, 2024
@jen-huang
Revert "[UII] Fix client-side validation for agent policy timeout fie…
d4a43e5 
…lds (elastic#191674)" (elastic#194338)

## Summary

Resolves elastic#194221.

This PR reverts commit f29bf1c. Timeout
fields should be clearable with undefined value or zero.

(cherry picked from commit 6792cb4)
kibanamachine added a commit that referenced this issue Sep 30, 2024
@kibanamachine @jen-huang
[8.x] Revert "[UII] Fix client-side validation for agent policy …
32f83be 
…timeout fields (#191674)" (#194338) (#194491)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Revert "[UII] Fix client-side validation for agent policy
timeout fields (#191674)"
(#194338)](#194338)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-09-30T21:22:37Z","message":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis
PR reverts commit f29bf1c.
Timeout\r\nfields should be clearable with undefined value or
zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\"","number":194338,"url":"https://github.com/elastic/kibana/pull/194338","mergeCommit":{"message":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis
PR reverts commit f29bf1c.
Timeout\r\nfields should be clearable with undefined value or
zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194338","number":194338,"mergeCommit":{"message":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis
PR reverts commit f29bf1c.
Timeout\r\nfields should be clearable with undefined value or
zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3"}}]}] BACKPORT-->

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "[UII] Fix client-side validation for agent policy timeout fields (#191674)" jen-huang/kibana
2 participants
@jen-huang @elasticmachine