Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocViewer always renders first tab ignoring shouldShow #19827

Closed
timroes opened this issue Jun 12, 2018 · 0 comments · Fixed by #42116
Closed

DocViewer always renders first tab ignoring shouldShow #19827

timroes opened this issue Jun 12, 2018 · 0 comments · Fixed by #42116
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Jun 12, 2018

Every docView can implement a shouldShow method, to tell if it should be visible for a specific document or not. Unfortunately doc_viewer.js will always set the first tab in order as active, without checking if it is actually visible for that document.

We need to fix this, and maybe switch to regular templating in that directive instead of doing manual templating via a function in case there is no reason for that anymore.

@timroes timroes added bug Fixes for quality problems that affect the customer experience :Discovery triage_needed labels Jun 12, 2018
@timroes timroes added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Discovery labels Sep 16, 2018
@kertal kertal mentioned this issue Aug 20, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants