-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-angularize DocViewer #42116
Merged
Merged
De-angularize DocViewer #42116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
commented
Jul 31, 2019
src/legacy/core_plugins/kbn_doc_views/public/views/table_helper.js
Outdated
Show resolved
Hide resolved
kertal
added
Feature:Discover
Discover Application
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
labels
Aug 1, 2019
Pinging @elastic/kibana-app |
kertal
commented
Aug 13, 2019
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
streamich
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on Mac/Chrome.
You might want to try useLayoutEffect
, otherwise just minor nits.
src/legacy/core_plugins/kibana/public/doc_viewer/doc_viewer_tab.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/doc_viewer/doc_viewer_tab.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/doc_viewer/doc_viewer_render_tab.tsx
Show resolved
Hide resolved
💔 Build Failed |
- instead of Component & FunctionComponent
💚 Build Succeeded |
💚 Build Succeeded |
ℹ️ I'll merge this into 7.x when #43240 is ready |
Closed
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 27, 2019
* Migrate doc-viewer directive to use React/TypeScript * Refactor DocViewsRegistryProvider * Add compatibility for 3rd party plugins still using angular * Add tests Angular rendering for usage in React component: Co-authored-by: spalger <email@spalger.com>
kertal
added a commit
that referenced
this pull request
Aug 27, 2019
* Migrate doc-viewer directive to use React/TypeScript * Refactor DocViewsRegistryProvider * Add compatibility for 3rd party plugins still using angular * Add tests Angular rendering for usage in React component: Co-authored-by: spalger <email@spalger.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Discover
Discover Application
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.4.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DocViewer is currently used by
discover
anddoc
. It provides a detailed view about the currently selected Elasticsearch doc. Out of the box it provides 2 tabs, a table view and a JSON view. It's is extendable by theDocViewsRegistry
. While the goal is to remove Angular completely, it has to be considered, that 3rd party plugins still use Angular.Here are some 3rd party plugins
https://github.com/sw-jung/kibana_markdown_doc_view
https://github.com/AntonPalyok/LA-Message-View
Existing angular plugins are auto converted to using a
render
function.Old plugin structure
New plugin structure 1, providing a component
New plugin structure 2, using a render function
Part of #38646
Fixes #19827 (as a side effect)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers