Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] Fix the link to discover test #201189

Closed
jennypavlova opened this issue Nov 21, 2024 · 0 comments · Fixed by #201197
Closed

[Inventory] Fix the link to discover test #201189

jennypavlova opened this issue Nov 21, 2024 · 0 comments · Fixed by #201197
Assignees
@jennypavlova
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@jennypavlova
Copy link
Member

No description provided.

@jennypavlova jennypavlova added failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 21, 2024
@jennypavlova jennypavlova self-assigned this Nov 21, 2024
@jennypavlova jennypavlova mentioned this issue Nov 21, 2024
Merged
jennypavlova added a commit that referenced this issue Nov 21, 2024
@jennypavlova
[Inventory] Fix the link to discover test (#201197)
74cf5d4 
Closes #201189

## Summary

After this fix was added in
#200984 the test started failing
as it was verifying the previous kuery value - it was missing the `" "`
so after this bug was fixed the test should be updated as well
(basically changing `container.id:foo` with `container.id:"foo"`) and
this PR updates the test.

I checked locally and the test is passing now.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 21, 2024
@jennypavlova
[Inventory] Fix the link to discover test (elastic#201197)
7806efd 
Closes elastic#201189

## Summary

After this fix was added in
elastic#200984 the test started failing
as it was verifying the previous kuery value - it was missing the `" "`
so after this bug was fixed the test should be updated as well
(basically changing `container.id:foo` with `container.id:"foo"`) and
this PR updates the test.

I checked locally and the test is passing now.

(cherry picked from commit 74cf5d4)
kibanamachine added a commit that referenced this issue Nov 21, 2024
@kibanamachine @jennypavlova
[8.x] [Inventory] Fix the link to discover test (#201197) (#201252)
b342de5 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Fix the link to discover test
(#201197)](#201197)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T17:14:43Z","message":"[Inventory]
Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n##
Summary\r\n\r\nAfter this fix was added
in\r\nhttps://github.com//pull/200984 the test started
failing\r\nas it was verifying the previous kuery value - it was missing
the `\" \"`\r\nso after this bug was fixed the test should be updated as
well\r\n(basically changing `container.id:foo` with
`container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI
checked locally and the test is passing
now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[Inventory]
Fix the link to discover
test","number":201197,"url":"https://github.com/elastic/kibana/pull/201197","mergeCommit":{"message":"[Inventory]
Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n##
Summary\r\n\r\nAfter this fix was added
in\r\nhttps://github.com//pull/200984 the test started
failing\r\nas it was verifying the previous kuery value - it was missing
the `\" \"`\r\nso after this bug was fixed the test should be updated as
well\r\n(basically changing `container.id:foo` with
`container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI
checked locally and the test is passing
now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201197","number":201197,"mergeCommit":{"message":"[Inventory]
Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n##
Summary\r\n\r\nAfter this fix was added
in\r\nhttps://github.com//pull/200984 the test started
failing\r\nas it was verifying the previous kuery value - it was missing
the `\" \"`\r\nso after this bug was fixed the test should be updated as
well\r\n(basically changing `container.id:foo` with
`container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI
checked locally and the test is passing
now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b"}}]}] BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
crespocarlos pushed a commit to crespocarlos/kibana that referenced this issue Nov 22, 2024
@jennypavlova
[Inventory] Fix the link to discover test (elastic#201197)
1637c23 
Closes elastic#201189

## Summary

After this fix was added in
elastic#200984 the test started failing
as it was verifying the previous kuery value - it was missing the `" "`
so after this bug was fixed the test should be updated as well
(basically changing `container.id:foo` with `container.id:"foo"`) and
this PR updates the test.

I checked locally and the test is passing now.

(cherry picked from commit 74cf5d4)
crespocarlos added a commit that referenced this issue Nov 22, 2024
@crespocarlos @jennypavlova
[8.17] [Inventory] Fix the link to discover test (#201197) (#201326)
3c2c4f2 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[Inventory] Fix the link to discover test
(#201197)](#201197)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T17:14:43Z","message":"[Inventory]
Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n##
Summary\r\n\r\nAfter this fix was added
in\r\nhttps://github.com//pull/200984 the test started
failing\r\nas it was verifying the previous kuery value - it was missing
the `\" \"`\r\nso after this bug was fixed the test should be updated as
well\r\n(basically changing `container.id:foo` with
`container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI
checked locally and the test is passing
now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"number":201197,"url":"https://github.com/elastic/kibana/pull/201197","mergeCommit":{"message":"[Inventory]
Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n##
Summary\r\n\r\nAfter this fix was added
in\r\nhttps://github.com//pull/200984 the test started
failing\r\nas it was verifying the previous kuery value - it was missing
the `\" \"`\r\nso after this bug was fixed the test should be updated as
well\r\n(basically changing `container.id:foo` with
`container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI
checked locally and the test is passing
now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201197","number":201197,"mergeCommit":{"message":"[Inventory]
Fix the link to discover test (#201197)\n\nCloses #201189\r\n\r\n##
Summary\r\n\r\nAfter this fix was added
in\r\nhttps://github.com//pull/200984 the test started
failing\r\nas it was verifying the previous kuery value - it was missing
the `\" \"`\r\nso after this bug was fixed the test should be updated as
well\r\n(basically changing `container.id:foo` with
`container.id:\"foo\"`) and\r\nthis PR updates the test.\r\n\r\nI
checked locally and the test is passing
now.","sha":"74cf5d45784b9f633decae428c61ff96281dcc4b"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201252","number":201252,"state":"MERGED","mergeCommit":{"sha":"b342de58951e78ad8921704499231a9d78100ca9","message":"[8.x]
[Inventory] Fix the link to discover test (#201197) (#201252)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.x`:\n- [[Inventory] Fix the link to discover
test\n(#201197)](https://github.com/elastic/kibana/pull/201197)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"jennypavlova\",\"email\":\"dzheni.pavlova@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-11-21T17:14:43Z\",\"message\":\"[Inventory]\nFix
the link to discover test (#201197)\\n\\nCloses
#201189\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAfter this fix was
added\nin\\r\\nhttps://github.com//pull/200984 the test
started\nfailing\\r\\nas it was verifying the previous kuery value - it
was missing\nthe `\\\" \\\"`\\r\\nso after this bug was fixed the test
should be updated as\nwell\\r\\n(basically changing `container.id:foo`
with\n`container.id:\\\"foo\\\"`) and\\r\\nthis PR updates the
test.\\r\\n\\r\\nI\nchecked locally and the test is
passing\nnow.\",\"sha\":\"74cf5d45784b9f633decae428c61ff96281dcc4b\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\"],\"title\":\"[Inventory]\nFix
the link to
discover\ntest\",\"number\":201197,\"url\":\"https://github.com/elastic/kibana/pull/201197\",\"mergeCommit\":{\"message\":\"[Inventory]\nFix
the link to discover test (#201197)\\n\\nCloses
#201189\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAfter this fix was
added\nin\\r\\nhttps://github.com//pull/200984 the test
started\nfailing\\r\\nas it was verifying the previous kuery value - it
was missing\nthe `\\\" \\\"`\\r\\nso after this bug was fixed the test
should be updated as\nwell\\r\\n(basically changing `container.id:foo`
with\n`container.id:\\\"foo\\\"`) and\\r\\nthis PR updates the
test.\\r\\n\\r\\nI\nchecked locally and the test is
passing\nnow.\",\"sha\":\"74cf5d45784b9f633decae428c61ff96281dcc4b\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/201197\",\"number\":201197,\"mergeCommit\":{\"message\":\"[Inventory]\nFix
the link to discover test (#201197)\\n\\nCloses
#201189\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nAfter this fix was
added\nin\\r\\nhttps://github.com//pull/200984 the test
started\nfailing\\r\\nas it was verifying the previous kuery value - it
was missing\nthe `\\\" \\\"`\\r\\nso after this bug was fixed the test
should be updated as\nwell\\r\\n(basically changing `container.id:foo`
with\n`container.id:\\\"foo\\\"`) and\\r\\nthis PR updates the
test.\\r\\n\\r\\nI\nchecked locally and the test is
passing\nnow.\",\"sha\":\"74cf5d45784b9f633decae428c61ff96281dcc4b\"}}]}]
BACKPORT-->\n\nCo-authored-by: jennypavlova
<dzheni.pavlova@elastic.co>"}}]}] BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@jennypavlova @paulinashakirova
[Inventory] Fix the link to discover test (elastic#201197)
9a7334f 
Closes elastic#201189

## Summary

After this fix was added in
elastic#200984 the test started failing
as it was verifying the previous kuery value - it was missing the `" "`
so after this bug was fixed the test should be updated as well
(basically changing `container.id:foo` with `container.id:"foo"`) and
this PR updates the test.

I checked locally and the test is passing now.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@jennypavlova @CAWilson94
[Inventory] Fix the link to discover test (elastic#201197)
8cfc2b8 
Closes elastic#201189

## Summary

After this fix was added in
elastic#200984 the test started failing
as it was verifying the previous kuery value - it was missing the `" "`
so after this bug was fixed the test should be updated as well
(basically changing `container.id:foo` with `container.id:"foo"`) and
this PR updates the test.

I checked locally and the test is passing now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Inventory] Fix the link to discover test jennypavlova/kibana
1 participant
@jennypavlova