Fix flaky visualize lab mode tests

[liza-mae]

Testing 6.3.x baseline for cloud, the visualize lab mode tests are failing. Looks like it needs some wait for page to load in certain areas and some logic in discover page object to be updated, will pull a PR to fix.

[tylersmalley]

Is this related to #19743?

[liza-mae]

Possibly it is related.

[liza-mae]

This is the test that is failing:

└- ✖ fail: "visualize app visualize lab mode disabling does not break loading saved searches"
│ tryForTime timeout: [POST http://localhost:9515/session/1a4a7d6a8c0c73e3521c4ef0f49bd0fc/element / {"using":"partial link text","value":"visualize_lab_mode_test"}] no such element: Unable to locate element: {"method":"partial link text","selector":"visualize_lab_mode_test"}
│ (Session info: chrome=67.0.3396.87)
│ (Driver info: chromedriver=2.36.540471 (9c759b81a907e70363c6312294d30b6ccccc2752),platform=Linux 4.8.0-36-generic x86_64)
│ at Server._post (/home/liza/Kibana/kibana-6.3/test/functional/services/remote/verbose_remote_logging.js:15:21)
│ at runRequest (/home/liza/Kibana/kibana-6.3/node_modules/leadfoot/Session.js:92:40)
│ at /home/liza/Kibana/kibana-6.3/node_modules/leadfoot/Session.js:113:39
│ at new Promise (/home/liza/Kibana/kibana-6.3/node_modules/dojo/_debug/Promise.ts:411:4)
│ at Session._post (/home/liza/Kibana/kibana-6.3/node_modules/leadfoot/Session.js:67:10)
│ at Session.find (/home/liza/Kibana/kibana-6.3/node_modules/leadfoot/Session.js:1304:15)
│ at Command. (/home/liza/Kibana/kibana-6.3/node_modules/leadfoot/Command.js:42:36)
│ at /home/liza/Kibana/kibana-6.3/node_modules/dojo/_debug/Promise.ts:393:16
│ at run (/home/liza/Kibana/kibana-6.3/node_modules/dojo/_debug/Promise.ts:237:8)
│ at /home/liza/Kibana/kibana-6.3/node_modules/dojo/_debug/nextTick.ts:44:4
│ at _combinedTickCallback (internal/process/next_tick.js:131:7)
│ at process._tickCallback (internal/process/next_tick.js:180:9)
│ at Command.find (/home/liza/Kibana/kibana-6.3/node_modules/leadfoot/Command.js:23:10)
│ at Command.prototype.(anonymous function) [as findByPartialLinkText] (/home/liza/Kibana/kibana-6.3/node_modules/leadfoot/lib/strategies.js:29:16)
│ at _ensureElementWithTimeout (/home/liza/Kibana/kibana-6.3/test/functional/services/find.js:100:29)
│ at retry.try (/home/liza/Kibana/kibana-6.3/test/functional/services/find.js:32:33)
│ at tryCatcher (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/util.js:26:23)
│ at Function.Promise.attempt.Promise.try (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/method.js:31:24)
│ at attempt (/home/liza/Kibana/kibana-6.3/test/common/services/retry.js:22:16)
│ at tryCatcher (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/util.js:26:23)
│ at Promise._settlePromiseFromHandler (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/promise.js:503:31)
│ at Promise._settlePromiseAt (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/promise.js:577:18)
│ at Promise._settlePromises (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/promise.js:693:14)
│ at Async._drainQueue (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/async.js:123:16)
│ at Async._drainQueues (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/async.js:133:10)
│ at Immediate.Async.drainQueues [as _onImmediate] (/home/liza/Kibana/kibana-6.3/node_modules/bluebird/js/main/async.js:15:14)
│ at runCallback (timers.js:810:20)
│ at tryOnImmediate (timers.js:768:5)

[liza-mae]

Merged fix #20165, closing