Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky visualize lab mode tests #20165

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Fix flaky visualize lab mode tests #20165

merged 2 commits into from
Jun 26, 2018

Conversation

liza-mae
Copy link
Contributor

Fix for issue #20157

  • Update saveSearch method in discover page.
  • Add wait for page to load in advance settings page.

@liza-mae liza-mae requested a review from timroes June 22, 2018 17:48
@liza-mae liza-mae added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Jun 22, 2018
@liza-mae liza-mae self-assigned this Jun 22, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes reviewed Jun 25, 2018
View reviewed changes
test/functional/page_objects/discover_page.js
}
});
await testSubjects.exists('loadSearchForm');
await PageObjects.header.waitUntilLoadingHasFinished();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am rather sure, that won't be enough to fix the issue with the flakyness. Unfortunately we don't have any failed test runs anymore, but in the ones I debugged, that had that failure, the loadSearchForm wasn't even present in the HTML, i.e. the button has been clicked, but the panel never properly expanded. So just waiting for something after the panel is there, won't help against that flakyness.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the huge amount of test passes in this PR, maybe it fixed it after all.. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timroes I was able to reproduce this error locally and the changes in this PR did fix the issue. I ran it 20 times locally with this fix and did not see the error once vs it would occur about every time without the fix.

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Jun 25, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor Author

The last CI failure is not from the test but on intake.

@liza-mae
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should keep an eye on that test

@liza-mae liza-mae merged commit 2acb026 into elastic:master Jun 26, 2018
@liza-mae liza-mae mentioned this pull request Jun 26, 2018
Merged
liza-mae added a commit to liza-mae/kibana that referenced this pull request Jun 26, 2018
@liza-mae
Fix flaky visualize lab mode tests (elastic#20165)
997a6a5 
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
liza-mae added a commit to liza-mae/kibana that referenced this pull request Jun 26, 2018
@liza-mae
Fix flaky visualize lab mode tests (elastic#20165)
a9c5a3d 
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
@liza-mae liza-mae mentioned this pull request Jun 26, 2018
Merged
@liza-mae liza-mae deleted the fix/issue-20157 branch June 26, 2018 17:45
liza-mae added a commit that referenced this pull request Jun 26, 2018
@liza-mae
Fix flaky visualize lab mode tests (#20165) (#20234)
7f59b12 
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
liza-mae added a commit that referenced this pull request Jun 26, 2018
@liza-mae
Fix flaky visualize lab mode tests (#20165) (#20233)
9ff7ad3 
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
@liza-mae liza-mae mentioned this pull request Jun 26, 2018
Closed
mattapperson pushed a commit that referenced this pull request Jun 28, 2018
@liza-mae @mattapperson
Fix flaky visualize lab mode tests (#20165)
bc24f50 
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
@cjcenizal cjcenizal mentioned this pull request Jul 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees

@liza-mae liza-mae

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test v6.3.1 v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liza-mae @elasticmachine @timroes