Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include @kbn/react-kibana-context-* and @kbn/shared-ux-router into shared bundle #204761

Closed
Dosant opened this issue Dec 18, 2024 · 2 comments
Closed

Include @kbn/react-kibana-context-* and @kbn/shared-ux-router into shared bundle #204761

Dosant opened this issue Dec 18, 2024 · 2 comments
Assignees
@Dosant
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 18, 2024

While reviewing #204547 (comment) I noticed that shared-ux/router is include in every bundle, it is probably worth adding it into shared bundle.

In addition, it is worth reviewing all commonly used shared-ux utils like KibanaRenderContextProvider which are expected to be used by every app.
@Dosant Dosant added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Dec 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant self-assigned this Dec 19, 2024
@Dosant
Copy link
Contributor Author

Dosant commented Dec 19, 2024

Router to shared bundle #204786
-181.6KB async chunks, -6.5Kb Page load bundle

Context Packages to shared bundle - #204794
-300Kb async chunks, -177kb Page load bundle

I think it is worth doing both

This was referenced Dec 19, 2024
Merged
Merged
@Dosant Dosant changed the title Include shared-ux/router into shared bundle Include @kbn/react-kibana-context-* and @kbn/shared-ux-router into shared bundle Dec 19, 2024
Dosant added a commit that referenced this issue Dec 30, 2024
@Dosant
Add @kbn/react-kibana-context-* packages to shared bundle (#204794)
39d8d7d 
## Summary

Part of #204761

These packages are meant to be used by each render tree.
`react-kibana-context-theme` was already part of a shared bundle and
most of them were already part of Bazel, let's add all of them for
consistency and to reduce bundle size
Dosant added a commit that referenced this issue Dec 30, 2024
@Dosant
Add @kbn/shared-ux-router to shared bundle (#204786)
b64ff10 
## Summary

Part of #204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.
@Dosant Dosant closed this as completed Dec 30, 2024
Dosant added a commit to Dosant/kibana that referenced this issue Dec 30, 2024
@Dosant
Add @kbn/react-kibana-context-* packages to shared bundle (elastic#…
818ef98 
…204794)

## Summary

Part of elastic#204761

These packages are meant to be used by each render tree.
`react-kibana-context-theme` was already part of a shared bundle and
most of them were already part of Bazel, let's add all of them for
consistency and to reduce bundle size

(cherry picked from commit 39d8d7d)

# Conflicts:
#	packages/kbn-ui-shared-deps-src/BUILD.bazel
#	packages/kbn-ui-shared-deps-src/src/definitions.js
#	packages/kbn-ui-shared-deps-src/src/entry.js
Dosant added a commit to Dosant/kibana that referenced this issue Dec 30, 2024
@Dosant
Add @kbn/shared-ux-router to shared bundle (elastic#204786)
05e938b 
## Summary

Part of elastic#204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.

(cherry picked from commit b64ff10)
Dosant added a commit that referenced this issue Dec 31, 2024
@Dosant
[8.x] Add @kbn/shared-ux-router to shared bundle (#204786) (#205278)
13aed70 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Add `@kbn/shared-ux-router` to shared bundle
(#204786)](#204786)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-12-30T12:44:44Z","message":"Add
`@kbn/shared-ux-router` to shared bundle (#204786)\n\n##
Summary\r\n\r\nPart of #204761 .
This package\r\nis used by every app and I thought it is worth adding it
to the shared\r\nbundle. Especially since it is already part of
Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":204786,"url":"https://github.com/elastic/kibana/pull/204786","mergeCommit":{"message":"Add
`@kbn/shared-ux-router` to shared bundle (#204786)\n\n##
Summary\r\n\r\nPart of #204761 .
This package\r\nis used by every app and I thought it is worth adding it
to the shared\r\nbundle. Especially since it is already part of
Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204786","number":204786,"mergeCommit":{"message":"Add
`@kbn/shared-ux-router` to shared bundle (#204786)\n\n##
Summary\r\n\r\nPart of #204761 .
This package\r\nis used by every app and I thought it is worth adding it
to the shared\r\nbundle. Especially since it is already part of
Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e"}}]}]
BACKPORT-->
stratoula pushed a commit to stratoula/kibana that referenced this issue Jan 2, 2025
@Dosant @stratoula
Add @kbn/react-kibana-context-* packages to shared bundle (elastic#…
5dc5710 
…204794)

## Summary

Part of elastic#204761

These packages are meant to be used by each render tree.
`react-kibana-context-theme` was already part of a shared bundle and
most of them were already part of Bazel, let's add all of them for
consistency and to reduce bundle size
stratoula pushed a commit to stratoula/kibana that referenced this issue Jan 2, 2025
@Dosant @stratoula
Add @kbn/shared-ux-router to shared bundle (elastic#204786)
2f21cb3 
## Summary

Part of elastic#204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.
benakansara pushed a commit to benakansara/kibana that referenced this issue Jan 2, 2025
@Dosant @benakansara
Add @kbn/react-kibana-context-* packages to shared bundle (elastic#…
fc714a5 
…204794)

## Summary

Part of elastic#204761

These packages are meant to be used by each render tree.
`react-kibana-context-theme` was already part of a shared bundle and
most of them were already part of Bazel, let's add all of them for
consistency and to reduce bundle size
benakansara pushed a commit to benakansara/kibana that referenced this issue Jan 2, 2025
@Dosant @benakansara
Add @kbn/shared-ux-router to shared bundle (elastic#204786)
8fbab2c 
## Summary

Part of elastic#204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Jan 2, 2025
@Dosant @cqliu1
Add @kbn/react-kibana-context-* packages to shared bundle (elastic#…
7b72325 
…204794)

## Summary

Part of elastic#204761

These packages are meant to be used by each render tree.
`react-kibana-context-theme` was already part of a shared bundle and
most of them were already part of Bazel, let's add all of them for
consistency and to reduce bundle size
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Jan 2, 2025
@Dosant @cqliu1
Add @kbn/shared-ux-router to shared bundle (elastic#204786)
97784ab 
## Summary

Part of elastic#204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dosant @elasticmachine